Issue 11308068: Remove the old wallpaper picker code

Issue 11308068: Remove the old wallpaper picker code (Closed)

Created:
8 years, 1 month ago by bshe

Modified:
8 years, 1 month ago

Reviewers:
Nikita (slow), James Hawkins

CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, arv (Not doing code reviews), oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove the old wallpaper picker code BUG=141431 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168532

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase to master #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1514 lines)			Patch
M	chrome/browser/chromeos/extensions/wallpaper_private_api.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/mock_user_manager.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/user.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager.h	View		2 chunks	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.h	View		2 chunks	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.cc	View		3 chunks	+0 lines, -38 lines	0 comments	Download
M	chrome/browser/chromeos/login/wallpaper_manager.h	View	1	10 chunks	+5 lines, -52 lines	0 comments	Download
M	chrome/browser/chromeos/login/wallpaper_manager.cc	View	1	14 chunks	+18 lines, -272 lines	0 comments	Download
D	chrome/browser/resources/options/chromeos/set_wallpaper_options.css	View		1 chunk	+0 lines, -51 lines	0 comments	Download
D	chrome/browser/resources/options/chromeos/set_wallpaper_options.html	View		1 chunk	+0 lines, -33 lines	0 comments	Download
D	chrome/browser/resources/options/chromeos/set_wallpaper_options.js	View		1 chunk	+0 lines, -324 lines	0 comments	Download
M	chrome/browser/resources/options/options.html	View		1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/browser/ui/webui/options/chromeos/set_wallpaper_options_handler.h	View		1 chunk	+0 lines, -96 lines	0 comments	Download
D	chrome/browser/ui/webui/options/chromeos/set_wallpaper_options_handler.cc	View		1 chunk	+0 lines, -258 lines	0 comments	Download
D	chrome/browser/ui/webui/options/chromeos/wallpaper_thumbnail_source.h	View		1 chunk	+0 lines, -83 lines	0 comments	Download
D	chrome/browser/ui/webui/options/chromeos/wallpaper_thumbnail_source.cc	View		1 chunk	+0 lines, -259 lines	0 comments	Download
M	chrome/browser/ui/webui/options/options_ui.cc	View	1	3 chunks	+0 lines, -15 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bshe

This CL is basically remove some old code that we no longer use. Note I ...

8 years, 1 month ago (2012-11-16 15:26:04 UTC) #1

Nikita (slow)

lgtm https://codereview.chromium.org/11308068/diff/1/chrome/browser/chromeos/login/user.cc File chrome/browser/chromeos/login/user.cc (right): https://codereview.chromium.org/11308068/diff/1/chrome/browser/chromeos/login/user.cc#newcode7 chrome/browser/chromeos/login/user.cc:7: #include "base/logging.h" nit: You could drop this include, ...

8 years, 1 month ago (2012-11-19 13:36:17 UTC) #3

bshe

8 years, 1 month ago (2012-11-19 14:41:35 UTC) #4

Thanks for review!

https://codereview.chromium.org/11308068/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/user.cc (right):

https://codereview.chromium.org/11308068/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/user.cc:7: #include "base/logging.h"
We have a DCHECK in this file. It looks like I need to keep this header for it.

On 2012/11/19 13:36:17, Nikita Kostylev wrote:
> nit: You could drop this include, not used.

Expand Messages | Collapse Messages