Chromium Code Reviews| Index: build/java.gypi |
| diff --git a/build/java.gypi b/build/java.gypi |
| index bd3976cab291df0b5df9ac7eefff2832fcd0cfcb..d65f94d110088180c6ce9eaded63ecac6f9186eb 100644 |
| --- a/build/java.gypi |
| +++ b/build/java.gypi |
| @@ -10,17 +10,12 @@ |
| # 'target_name': 'my-package_java', |
| # 'type': 'none', |
| # 'variables': { |
| -# 'package_name': 'my-package', |
| # 'java_in_dir': 'path/to/package/root', |
| # }, |
| # 'includes': ['path/to/this/gypi/file'], |
| # } |
| # |
| -# The generated jar-file will be: |
| -# <(PRODUCT_DIR)/lib.java/chromium_<(package_name).jar |
| # Required variables: |
| -# package_name - Used to name the intermediate output directory and in the |
| -# names of some output files. |
| # java_in_dir - The top-level java directory. The src should be in |
| # <java_in_dir>/src. |
| # Optional/automatic variables: |
| @@ -51,17 +46,12 @@ |
| 'dependencies': [ |
| '<(DEPTH)/build/build_output_dirs_android.gyp:build_output_dirs' |
| ], |
| - # This all_dependent_settings is used for java targets only. This will add the |
| - # chromium_<(package_name) jar to the classpath of dependent java targets. |
| - 'all_dependent_settings': { |
| - 'variables': { |
| - 'input_jars_paths': ['<(PRODUCT_DIR)/lib.java/chromium_<(package_name).jar'], |
| - }, |
| - }, |
| 'variables': { |
| 'input_jars_paths': [], |
| 'additional_src_dirs': [], |
| 'javac_includes': [], |
| + 'jar_name': '<(_target_name).jar', |
| + 'jar_path': '<(PRODUCT_DIR)/lib.java/<(jar_name)', |
| 'additional_input_paths': ['>@(additional_R_files)'], |
| 'generated_src_dirs': ['>@(generated_R_dirs)'], |
| 'generated_R_dirs': [], |
| @@ -69,12 +59,19 @@ |
| 'has_java_resources%': 0, |
| 'java_strings_grd%': '', |
| }, |
| + # This all_dependent_settings is used for java targets only. This will add the |
| + # jar path to the classpath of dependent java targets. |
| + 'all_dependent_settings': { |
| + 'variables': { |
| + 'input_jars_paths': ['<(jar_path)'], |
| + }, |
| + }, |
| 'conditions': [ |
| ['has_java_resources == 1', { |
| 'variables': { |
| 'res_dir': '<(java_in_dir)/res', |
| - 'out_res_dir': '<(SHARED_INTERMEDIATE_DIR)/<(package_name)/res', |
| - 'R_dir': '<(SHARED_INTERMEDIATE_DIR)/<(package_name)/java_R', |
| + 'out_res_dir': '<(SHARED_INTERMEDIATE_DIR)/<(_target_name)/res', |
| + 'R_dir': '<(SHARED_INTERMEDIATE_DIR)/<(_target_name)/java_R', |
| 'R_file': '<(R_dir)/<(R_package_relpath)/R.java', |
| 'R_text_file': '<(R_dir)/R.txt', |
| 'generated_src_dirs': ['<(R_dir)'], |
| @@ -115,7 +112,7 @@ |
| # Generate R.java and crunch image resources. |
| { |
| 'action_name': 'process_resources', |
| - 'message': 'processing resources for <(package_name)', |
| + 'message': 'processing resources for <(_target_name)', |
| 'conditions': [ |
| ['java_strings_grd != ""', { |
| 'inputs': [ |
| @@ -148,8 +145,8 @@ |
| ], |
| 'actions': [ |
| { |
| - 'action_name': 'ant_<(package_name)', |
| - 'message': 'Building <(package_name) java sources.', |
| + 'action_name': 'ant_<(_target_name)', |
| + 'message': 'Building <(_target_name) java sources.', |
| 'inputs': [ |
| 'android/ant/common.xml', |
| 'android/ant/chromium-jars.xml', |
| @@ -158,7 +155,7 @@ |
| '>@(additional_input_paths)', |
| ], |
| 'outputs': [ |
| - '<(PRODUCT_DIR)/lib.java/chromium_<(package_name).jar', |
| + '<(jar_path)', |
| ], |
| 'action': [ |
| 'ant', '-quiet', |
| @@ -173,8 +170,10 @@ |
| '-DADDITIONAL_SRC_DIRS=>(additional_src_dirs)', |
| '-DGENERATED_SRC_DIRS=>(generated_src_dirs)', |
| '-DINPUT_JARS_PATHS=>(input_jars_paths)', |
| - '-DPACKAGE_NAME=<(package_name)', |
| + '-DJAR_NAME=<(jar_name)', |
| + '-DOUT_DIR=<(ant_build_out)/<(_target_name)', |
| '-DJAVAC_INCLUDES=>(javac_includes)', |
| + '-DTARGET_NAME=<(_target_name)', |
|
Yaron
2013/02/20 18:42:01
Where is TARGET_NAME used?
|
| '-Dbasedir=<(java_in_dir)', |
| '-buildfile', |