Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/browser/extensions/web_view_browsertest.cc

Issue 11308024: Fixing guest processes to use the proper storage partition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/web_view_browsertest.cc
diff --git a/chrome/browser/extensions/web_view_browsertest.cc b/chrome/browser/extensions/web_view_browsertest.cc
index 2849cf459cb8c85d61829c686f97156c5f9713bb..c0d36b9a7acee982e2619d69fbf12967a9161085 100644
--- a/chrome/browser/extensions/web_view_browsertest.cc
+++ b/chrome/browser/extensions/web_view_browsertest.cc
@@ -100,15 +100,20 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, Isolation) {
&cookie_size, &cookie_value);
EXPECT_EQ("testCookie=1", cookie_value);
- // Now, test the browser tags to ensure we have properly set the cookie and
- // we have only one per browser tag and they are not the same.
+ // The default behavior is to combine browser tags with no explicit partition
+ // declaration into the same in-memory partition. Test the browser tags to
+ // ensure we have properly set the cookies and we have both cookies in both
+ // browser tags.
+ //
+ // TODO(ajwong): We should add a test in the javascript level that asserts the
+ // various storage types are isolated.
automation_util::GetCookies(GURL("http://localhost"),
source1->GetWebContents(),
&cookie_size, &cookie_value);
- EXPECT_EQ("guest1=true", cookie_value);
+ EXPECT_EQ("guest1=true; guest2=true", cookie_value);
automation_util::GetCookies(GURL("http://localhost"),
source2->GetWebContents(),
&cookie_size, &cookie_value);
- EXPECT_EQ("guest2=true", cookie_value);
+ EXPECT_EQ("guest1=true; guest2=true", cookie_value);
Finnur 2012/10/29 10:14:41 This is a bit hard to understand in isolation. Wha
}
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/profiles/off_the_record_profile_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698