Fixing guest processes to use the proper storage partition.

chrome/browser/extensions/web_view_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/automation_util.h"
 #include "chrome/browser/extensions/platform_app_browsertest_util.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "chrome/test/base/test_launcher_utils.h"
 #include "content/public/browser/notification_service.h"
@@ skipping 68 matching lines @@
   LoadAndLaunchPlatformApp("web_view_isolation");
   observer1.Wait();
   observer2.Wait();
 
   content::Source<content::NavigationController> source1 = observer1.source();
   EXPECT_TRUE(source1->GetWebContents()->GetRenderProcessHost()->IsGuest());
   content::Source<content::NavigationController> source2 = observer2.source();
   EXPECT_TRUE(source2->GetWebContents()->GetRenderProcessHost()->IsGuest());
   EXPECT_NE(source1->GetWebContents()->GetRenderProcessHost()->GetID(),
             source2->GetWebContents()->GetRenderProcessHost()->GetID());
+  EXPECT_EQ(
+      source1->GetWebContents()->GetRenderProcessHost()->GetStoragePartition(),
+      source2->GetWebContents()->GetRenderProcessHost()->GetStoragePartition());

[Charlie Reis, 2012/10/27 01:11:43]

Either we should get rid of this (to make it easier to remove
GetStoragePartition) or add a test for the bug (compare against the
StoragePartition of a normal tab).

[awong, 2012/10/27 01:23:54]

I TODOed it.

 
   EXPECT_TRUE(content::ExecuteJavaScript(
       source1->GetWebContents()->GetRenderViewHost(), std::wstring(),
       cookie_script1));
   EXPECT_TRUE(content::ExecuteJavaScript(
       source2->GetWebContents()->GetRenderViewHost(), std::wstring(),
       cookie_script2));
 
   // Test the regular browser context to ensure we still have only one cookie.
   automation_util::GetCookies(GURL("http://localhost"),
                               chrome::GetWebContentsAt(browser(), 0),
                               &cookie_size, &cookie_value);
   EXPECT_EQ("testCookie=1", cookie_value);
 
-  // Now, test the browser tags to ensure we have properly set the cookie and
-  // we have only one per browser tag and they are not the same.
+  // The default behavior is to combine browser tags with no explicit partition
+  // declaration into the same in-memory partition. Test the browser tags to
+  // ensure we have properly set the cookies and we have both cookies in both
+  // browser tags.
   automation_util::GetCookies(GURL("http://localhost"),
                               source1->GetWebContents(),
                               &cookie_size, &cookie_value);
-  EXPECT_EQ("guest1=true", cookie_value);
+  EXPECT_EQ("guest1=true; guest2=true", cookie_value);
 
   automation_util::GetCookies(GURL("http://localhost"),
                               source2->GetWebContents(),
                               &cookie_size, &cookie_value);
-  EXPECT_EQ("guest2=true", cookie_value);
+  EXPECT_EQ("guest1=true; guest2=true", cookie_value);
 }