Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: dart/lib/compiler/implementation/ssa/codegen.dart

Issue 11308006: Throw an exception when invariant fails and report nice diagnostic. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/lib/compiler/implementation/compiler.dart ('k') | dart/lib/compiler/implementation/tree/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/lib/compiler/implementation/ssa/codegen.dart
diff --git a/dart/lib/compiler/implementation/ssa/codegen.dart b/dart/lib/compiler/implementation/ssa/codegen.dart
index fdf877a754a08a2d1488902d9dd53081e471ac12..8e0a01cda98af0736a53a0e154cd8d20aba43fe7 100644
--- a/dart/lib/compiler/implementation/ssa/codegen.dart
+++ b/dart/lib/compiler/implementation/ssa/codegen.dart
@@ -2307,9 +2307,11 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
world.registerIsCheck(type);
Element element = type.element;
if (identical(element.kind, ElementKind.TYPE_VARIABLE)) {
- compiler.unimplemented("visitIs for type variables", instruction: node);
+ compiler.unimplemented("visitIs for type variables",
+ instruction: node.expression);
} else if (identical(element.kind, ElementKind.TYPEDEF)) {
- compiler.unimplemented("visitIs for typedefs", instruction: node);
+ compiler.unimplemented("visitIs for typedefs",
+ instruction: node.expression);
}
LibraryElement coreLibrary = compiler.coreLibrary;
ClassElement objectClass = compiler.objectClass;
« no previous file with comments | « dart/lib/compiler/implementation/compiler.dart ('k') | dart/lib/compiler/implementation/tree/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698