Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1130783008: Simplify test http_server_properties member access. (Closed)

Created:
5 years, 7 months ago by Bence
Modified:
5 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify test http_server_properties member access. Append underscore to the name of QuicNetworkTransactionTest::http_server_properties member to match other members. Use it directly instead of *(session_->http_server_properties) throughout tests. BUG= Committed: https://crrev.com/6be245c19fae40f10662ace782ddc85a05781ffb Cr-Commit-Position: refs/heads/master@{#330078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M net/quic/quic_network_transaction_unittest.cc View 4 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 7 months ago (2015-05-14 21:20:36 UTC) #2
Ryan Hamilton
lgtm
5 years, 7 months ago (2015-05-15 04:06:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130783008/1
5 years, 7 months ago (2015-05-15 11:21:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 11:24:12 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 11:25:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6be245c19fae40f10662ace782ddc85a05781ffb
Cr-Commit-Position: refs/heads/master@{#330078}

Powered by Google App Engine
This is Rietveld 408576698