Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1130783004: bluetooth: Enable BluetoothAdapterFactory on android. (Closed)

Created:
5 years, 7 months ago by scheib
Modified:
5 years, 7 months ago
Reviewers:
armansito
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bta-ut-permission-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Enable BluetoothAdapterFactory on android. BUG=471536 Committed: https://crrev.com/28d9c2fe07bd584c4ab604ef3d8d4c1cec288833 Cr-Commit-Position: refs/heads/master@{#329755}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M device/bluetooth/bluetooth_adapter_android.cc View 2 chunks +4 lines, -2 lines 2 comments Download
M device/bluetooth/bluetooth_adapter_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
scheib
5 years, 7 months ago (2015-05-12 22:00:55 UTC) #2
armansito
lgtm with one nit https://codereview.chromium.org/1130783004/diff/1/device/bluetooth/bluetooth_adapter_android.cc File device/bluetooth/bluetooth_adapter_android.cc (left): https://codereview.chromium.org/1130783004/diff/1/device/bluetooth/bluetooth_adapter_android.cc#oldcode149 device/bluetooth/bluetooth_adapter_android.cc:149: const ErrorCallback& error_callback) { Would ...
5 years, 7 months ago (2015-05-12 22:39:33 UTC) #3
scheib
https://codereview.chromium.org/1130783004/diff/1/device/bluetooth/bluetooth_adapter_android.cc File device/bluetooth/bluetooth_adapter_android.cc (left): https://codereview.chromium.org/1130783004/diff/1/device/bluetooth/bluetooth_adapter_android.cc#oldcode149 device/bluetooth/bluetooth_adapter_android.cc:149: const ErrorCallback& error_callback) { On 2015/05/12 22:39:33, armansito wrote: ...
5 years, 7 months ago (2015-05-13 22:54:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130783004/1
5 years, 7 months ago (2015-05-13 22:54:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 00:11:46 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 00:13:35 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/28d9c2fe07bd584c4ab604ef3d8d4c1cec288833
Cr-Commit-Position: refs/heads/master@{#329755}

Powered by Google App Engine
This is Rietveld 408576698