Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1130783002: Migrate error messages, part 9. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Migrate error messages, part 9. R=mvstanton@chromium.org Committed: https://crrev.com/f8db4327ade90715649d4571c5199f306fae4dff Cr-Commit-Position: refs/heads/master@{#28291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -54 lines) Patch
M src/accessors.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/factory.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/factory.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M src/ic/ic.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M src/messages.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/messages.js View 2 chunks +0 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/runtime/runtime-classes.cc View 4 chunks +6 lines, -13 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-scopes.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/messages.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 7 months ago (2015-05-06 14:00:40 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130783002/1
5 years, 7 months ago (2015-05-06 14:00:57 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-06 14:30:59 UTC) #5
mvstanton
lgtm
5 years, 7 months ago (2015-05-07 09:55:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130783002/1
5 years, 7 months ago (2015-05-07 09:58:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 10:00:26 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 10:00:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8db4327ade90715649d4571c5199f306fae4dff
Cr-Commit-Position: refs/heads/master@{#28291}

Powered by Google App Engine
This is Rietveld 408576698