Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: components/autofill/core/browser/autofill_external_delegate_unittest.cc

Issue 1130773004: mac: Add histograms to measure impact of Address Book integration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix some unit tests. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_external_delegate_unittest.cc
diff --git a/components/autofill/core/browser/autofill_external_delegate_unittest.cc b/components/autofill/core/browser/autofill_external_delegate_unittest.cc
index e9bef0665e5e22cae944150580c6ea8e970fa972..7c9d93a4fc6471996317640b656f693d377420c2 100644
--- a/components/autofill/core/browser/autofill_external_delegate_unittest.cc
+++ b/components/autofill/core/browser/autofill_external_delegate_unittest.cc
@@ -88,6 +88,11 @@ class MockAutofillManager : public AutofillManager {
MOCK_METHOD2(ShouldShowScanCreditCard,
bool(const FormData& form, const FormFieldData& field));
+ // This method is only used for emitting histograms, but makes assumptions
+ // about the internal state of the AutofillManager. Override it to do
+ // nothing.
+ void OnUserDidAcceptAutofillSuggestion(int unique_id) override {}
+
MOCK_METHOD5(FillOrPreviewForm,
void(AutofillDriver::RendererFormDataAction action,
int query_id,

Powered by Google App Engine
This is Rietveld 408576698