Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: components/autofill/core/browser/autofill_manager.h

Issue 1130773004: mac: Add histograms to measure impact of Address Book integration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from isherman, round five. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 349
350 // If |initial_interaction_timestamp_| is unset or is set to a later time than 350 // If |initial_interaction_timestamp_| is unset or is set to a later time than
351 // |interaction_timestamp|, updates the cached timestamp. The latter check is 351 // |interaction_timestamp|, updates the cached timestamp. The latter check is
352 // needed because IPC messages can arrive out of order. 352 // needed because IPC messages can arrive out of order.
353 void UpdateInitialInteractionTimestamp( 353 void UpdateInitialInteractionTimestamp(
354 const base::TimeTicks& interaction_timestamp); 354 const base::TimeTicks& interaction_timestamp);
355 355
356 // Shared code to determine if |form| should be uploaded. 356 // Shared code to determine if |form| should be uploaded.
357 bool ShouldUploadForm(const FormStructure& form); 357 bool ShouldUploadForm(const FormStructure& form);
358 358
359 #if defined(OS_MACOSX) && !defined(OS_IOS)
360 // Emits a UMA metric indicating whether the accepted Autofill suggestion is
361 // from the Mac Address Book.
362 void EmitIsFromAddressBookMetric(int unique_id);
363 #endif // defined(OS_MACOSX) && !defined(OS_IOS)
364
359 // Provides driver-level context to the shared code of the component. Must 365 // Provides driver-level context to the shared code of the component. Must
360 // outlive this object. 366 // outlive this object.
361 AutofillDriver* driver_; 367 AutofillDriver* driver_;
362 368
363 AutofillClient* const client_; 369 AutofillClient* const client_;
364 370
365 // Handles real PAN requests. 371 // Handles real PAN requests.
366 wallet::RealPanWalletClient real_pan_client_; 372 wallet::RealPanWalletClient real_pan_client_;
367 373
368 std::string app_locale_; 374 std::string app_locale_;
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
476 AutocompleteOffRespectedForAutocomplete); 482 AutocompleteOffRespectedForAutocomplete);
477 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 483 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
478 DontSaveCvcInAutocompleteHistory); 484 DontSaveCvcInAutocompleteHistory);
479 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSaveWalletCard); 485 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSaveWalletCard);
480 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 486 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
481 }; 487 };
482 488
483 } // namespace autofill 489 } // namespace autofill
484 490
485 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 491 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698