mac: Add histograms to measure impact of Address Book integration.

components/autofill/core/browser/personal_data_manager_mac.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <math.h>
 
 #import <AddressBook/AddressBook.h>
 
 #include "base/format_macros.h"
 #include "base/guid.h"
 #include "base/logging.h"
 #import "base/mac/scoped_nsexception_enabler.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
+#include "base/time/time.h"
 #include "components/autofill/core/browser/autofill_country.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/autofill_type.h"
 #include "components/autofill/core/browser/form_structure.h"
 #include "components/autofill/core/browser/phone_number.h"
 #include "components/autofill/core/common/autofill_pref_names.h"
 #include "components/autofill/core/common/form_data.h"
 #include "grit/components_strings.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 
@@ skipping 41 matching lines @@
 // Records a UMA metric indicating whether an attempt to access the Address
 // Book was skipped because doing so would cause the Address Book permissions
 // prompt to incorrectly appear.
 void RecordAccessSkipped(bool skipped) {
   UMA_HISTOGRAM_BOOLEAN("Autofill.AddressBook.AccessSkipped", skipped);
 }
 
 ABAddressBook* GetAddressBook(PrefService* pref_service) {
   bool first_access = !HasQueriedMacAddressBook(pref_service);
 
+  base::Time start_time = base::Time::Now();
   // +[ABAddressBook sharedAddressBook] throws an exception internally in
   // circumstances that aren't clear. The exceptions are only observed in crash
   // reports, so it is unknown whether they would be caught by AppKit and nil
   // returned, or if they would take down the app. In either case, avoid
   // crashing. http://crbug.com/129022
   ABAddressBook* addressBook = base::mac::RunBlockIgnoringExceptions(
       ^{ return [ABAddressBook sharedAddressBook]; });
   UMA_HISTOGRAM_BOOLEAN("Autofill.AddressBookAvailable", addressBook != nil);
 
+  if (!g_accessed_address_book) {
+    // The amount of time that the access takes gives a good indication as to
+    // whether the user was shown a prompt.
+    UMA_HISTOGRAM_TIMES("Autofill.AddressBook.AccessTime",
+                        base::Time::Now() - start_time);
+  }
+
   if (first_access) {
     UMA_HISTOGRAM_BOOLEAN("Autofill.AddressBookAvailableOnFirstAttempt",
                           addressBook != nil);
   }
 
   g_accessed_address_book = true;
   pref_service->SetBoolean(prefs::kAutofillMacAddressBookQueried, true);
   return addressBook;
 }
 
@@ skipping 61 matching lines @@
       RecordAccessSkipped(true);
     return;
   }
 
   if (record_metrics)
     RecordAccessSkipped(false);
 
   ABAddressBook* addressBook = GetAddressBook(pref_service);
 
   ABPerson* me = [addressBook me];
-  if (!me)
+  if (!me) {
+    UMA_HISTOGRAM_BOOLEAN("Autofill.AddressBook.ContainedUsefulInformation",

[Ilya Sherman, 2015/05/14 21:46:28]

For parallelism with existing histograms, please use MacAddressBook rather than
AddressBook (applies throughout)

[erikchen, 2015/05/15 21:04:50]

Done.

+                          false);
     return;
+  }
 
   ABMultiValue* addresses = [me valueForProperty:kABAddressProperty];
 
   // The number of characters at the end of the GUID to reserve for
   // distinguishing addresses within the "me" card.  Cap the number of addresses
   // we will fetch to the number that can be distinguished by this fragment of
   // the GUID.
   const size_t kNumAddressGUIDChars = 2;
   const size_t kNumHexDigits = 16;
   const size_t kMaxAddressCount = pow(kNumHexDigits, kNumAddressGUIDChars);
   NSUInteger count = MIN([addresses count], kMaxAddressCount);
+
+  UMA_HISTOGRAM_BOOLEAN("Autofill.AddressBook.ContainedUsefulInformation",

[Ilya Sherman, 2015/05/14 21:46:28]

I'd prefer not to repeat the string constant, to avoid the chance of typos. 
Please either define a wrapper function or at least a string constant.

[erikchen, 2015/05/15 21:04:50]

Done.

+                        count != 0);
+
   for (NSUInteger i = 0; i < count; i++) {
     NSDictionary* address = [addresses valueAtIndex:i];
     NSString* addressLabelRaw = [addresses labelAtIndex:i];
 
     // Create a new profile where the guid is set to the guid portion of the
     // |kABUIDProperty| taken from from the "me" address.  The format of
     // the |kABUIDProperty| is "<guid>:ABPerson", so we're stripping off the
     // raw guid here and using it directly, with one modification: we update the
     // last |kNumAddressGUIDChars| characters in the GUID to reflect the address
     // variant.  Note that we capped the number of addresses above, so this is
@@ skipping 214 matching lines @@
 
 int PersonalDataManager::AccessAddressBookPromptCount() {
   return pref_service_->GetInteger(prefs::kAutofillMacAddressBookShowedCount);
 }
 
 void PersonalDataManager::BinaryChanging() {
   g_binary_changed = true;
 }
 
 }  // namespace autofill