mac: Add histograms to measure impact of Address Book integration.

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
 #include <set>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/guid.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/field_trial.h"
+#include "base/metrics/histogram_macros.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
 #include "components/autofill/core/browser/autofill_client.h"
 #include "components/autofill/core/browser/autofill_data_model.h"
 #include "components/autofill/core/browser/autofill_experiments.h"
 #include "components/autofill/core/browser/autofill_external_delegate.h"
@@ skipping 663 matching lines @@
 }
 
 void AutofillManager::OnHidePopup() {
   if (!IsAutofillEnabled())
     return;
 
   autocomplete_history_manager_->CancelPendingQuery();
   client_->HideAutofillPopup();
 }
 
+void AutofillManager::OnUserDidAcceptAutofillSuggestion(int unique_id) {
+#if defined(OS_MACOSX) && !defined(OS_IOS)
+  size_t variant = 0;
+  const AutofillProfile* profile = nullptr;
+  bool result = GetProfile(unique_id, &profile, &variant);

[Ilya Sherman, 2015/05/18 21:36:22]

Rather than changing the test code, I think the production code should actually
bail if the unique_id is negative.  Does that resolve the test failures?

[erikchen, 2015/05/18 23:29:40]

It does not resolve all of the test failures. 

I also don't think that it's the best approach - unique_id is effectively an
opaque object, and there are methods that operate on it to return valid data.
Comparing it against 0 makes assumptions about the internal structure of
unique_id.

[Ilya Sherman, 2015/05/18 23:31:23]

It's not an opaque object.  What does your code do in production if an id of -1
is passed to this method?

What test failures remain if you compare against 0?

+  if (!result)
+    return;
+
+  bool is_from_address_book =
+      profile->record_type() == AutofillProfile::AUXILIARY_PROFILE;
+  UMA_HISTOGRAM_BOOLEAN(
+      "Autofill.MacAddressBook.AcceptedSuggestionIsFromAddressBook",
+      is_from_address_book);
+#endif  // defined(OS_MACOSX) && !defined(OS_IOS)
+}
+
 bool AutofillManager::RemoveAutofillProfileOrCreditCard(int unique_id) {
   std::string guid;
   size_t variant = 0;
   const CreditCard* credit_card = nullptr;
   const AutofillProfile* profile = nullptr;
   if (GetCreditCard(unique_id, &credit_card)) {
     if (credit_card->record_type() != CreditCard::LOCAL_CARD)
       return false;
 
     guid = credit_card->guid();
@@ skipping 798 matching lines @@
     return false;
 
   // Disregard forms that we wouldn't ever autofill in the first place.
   if (!form.ShouldBeParsed())
     return false;
 
   return true;
 }
 
 }  // namespace autofill