Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: runtime/bin/main.cc

Issue 1130753006: Hide Isolate pointer from embedder (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index db47bbc1be887da5ee5d7b1c44afa65e49169052..1373c29d0aeada9c3882cc09af4450ed475f2eb3 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -591,8 +591,8 @@ static Dart_Isolate CreateIsolateAndSetupHelper(const char* script_uri,
isolate_data,
error);
- if (isolate == NULL) {
- return NULL;
+ if (isolate == DART_ILLEGAL_ISOLATE) {
+ return DART_ILLEGAL_ISOLATE;
}
Dart_EnterScope();
@@ -964,7 +964,7 @@ void main(int argc, char** argv) {
commandline_package_root,
&error,
&exit_code);
- if (isolate == NULL) {
+ if (isolate == DART_ILLEGAL_ISOLATE) {
Log::PrintErr("%s\n", error);
free(error);
delete [] isolate_name;
@@ -974,7 +974,7 @@ void main(int argc, char** argv) {
Dart_EnterIsolate(isolate);
ASSERT(isolate == Dart_CurrentIsolate());
- ASSERT(isolate != NULL);
+ ASSERT(isolate != DART_ILLEGAL_ISOLATE);
Dart_Handle result;
Dart_EnterScope();

Powered by Google App Engine
This is Rietveld 408576698