Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: runtime/vm/native_api_impl.cc

Issue 1130753006: Hide Isolate pointer from embedder (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/json_stream.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "include/dart_native_api.h" 5 #include "include/dart_native_api.h"
6 6
7 #include "platform/assert.h" 7 #include "platform/assert.h"
8 #include "vm/dart_api_impl.h" 8 #include "vm/dart_api_impl.h"
9 #include "vm/dart_api_message.h" 9 #include "vm/dart_api_message.h"
10 #include "vm/dart_api_state.h" 10 #include "vm/dart_api_state.h"
(...skipping 26 matching lines...) Expand all
37 37
38 DART_EXPORT Dart_Port Dart_NewNativePort(const char* name, 38 DART_EXPORT Dart_Port Dart_NewNativePort(const char* name,
39 Dart_NativeMessageHandler handler, 39 Dart_NativeMessageHandler handler,
40 bool handle_concurrently) { 40 bool handle_concurrently) {
41 if (name == NULL) { 41 if (name == NULL) {
42 name = "<UnnamedNativePort>"; 42 name = "<UnnamedNativePort>";
43 } 43 }
44 if (handler == NULL) { 44 if (handler == NULL) {
45 OS::PrintErr("%s expects argument 'handler' to be non-null.\n", 45 OS::PrintErr("%s expects argument 'handler' to be non-null.\n",
46 CURRENT_FUNC); 46 CURRENT_FUNC);
47 return ILLEGAL_PORT; 47 return DART_ILLEGAL_PORT;
48 } 48 }
49 // Start the native port without a current isolate. 49 // Start the native port without a current isolate.
50 IsolateSaver saver(Isolate::Current()); 50 IsolateSaver saver(Isolate::Current());
51 Thread::ExitIsolate(); 51 Thread::ExitIsolate();
52 52
53 NativeMessageHandler* nmh = new NativeMessageHandler(name, handler); 53 NativeMessageHandler* nmh = new NativeMessageHandler(name, handler);
54 Dart_Port port_id = PortMap::CreatePort(nmh); 54 Dart_Port port_id = PortMap::CreatePort(nmh);
55 nmh->Run(Dart::thread_pool(), NULL, NULL, 0); 55 nmh->Run(Dart::thread_pool(), NULL, NULL, 0);
56 return port_id; 56 return port_id;
57 } 57 }
(...skipping 28 matching lines...) Expand all
86 Dart_Handle result = Api::CheckAndFinalizePendingClasses(isolate); 86 Dart_Handle result = Api::CheckAndFinalizePendingClasses(isolate);
87 if (::Dart_IsError(result)) { 87 if (::Dart_IsError(result)) {
88 return result; 88 return result;
89 } 89 }
90 CHECK_CALLBACK_STATE(isolate); 90 CHECK_CALLBACK_STATE(isolate);
91 CompileAll(isolate, &result); 91 CompileAll(isolate, &result);
92 return result; 92 return result;
93 } 93 }
94 94
95 } // namespace dart 95 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/json_stream.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698