Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1130753005: Get audio_unittests passing with h/w on windows. (Closed)

Created:
5 years, 7 months ago by watk
Modified:
5 years, 7 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get audio_unittests passing with h/w on windows. Ensure that audio_unittests pass with --require-audio-hardware-for-testing. * Convert tests to STA COM threads, not MTA. * Do COM thread initialization in AudioManager. * Disable exclusive mode tests. * Convert a couple of tests to use ABORT_AUDIO_TEST_IF_NOT. BUG=416594 TEST=audio_unittests --require-audio-hardware-for-testing Committed: https://crrev.com/c99b195f6abb12e617e8e14ef95b6403fc504f9f Cr-Commit-Position: refs/heads/master@{#329917}

Patch Set 1 #

Total comments: 1

Patch Set 2 : MTA -> STA #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -52 lines) Patch
M media/audio/audio_input_volume_unittest.cc View 2 chunks +1 line, -11 lines 0 comments Download
M media/audio/audio_manager.cc View 1 4 chunks +19 lines, -0 lines 0 comments Download
M media/audio/audio_manager_unittest.cc View 2 chunks +1 line, -11 lines 0 comments Download
M media/audio/win/audio_device_listener_win_unittest.cc View 1 4 chunks +5 lines, -6 lines 0 comments Download
M media/audio/win/audio_low_latency_input_win_unittest.cc View 4 chunks +1 line, -6 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 6 chunks +11 lines, -7 lines 0 comments Download
M media/audio/win/audio_output_win_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M media/audio/win/core_audio_util_win_unittest.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
watk
5 years, 7 months ago (2015-05-06 18:22:30 UTC) #2
DaleCurtis
lgtm https://codereview.chromium.org/1130753005/diff/1/media/audio/audio_manager.cc File media/audio/audio_manager.cc (right): https://codereview.chromium.org/1130753005/diff/1/media/audio/audio_manager.cc#newcode131 media/audio/audio_manager.cc:131: base::win::ScopedCOMInitializer::kMTA)); Did using a regular initializer (i.e. w/ ...
5 years, 7 months ago (2015-05-07 02:11:12 UTC) #3
watk
On 2015/05/07 02:11:12, DaleCurtis wrote: > lgtm > > https://codereview.chromium.org/1130753005/diff/1/media/audio/audio_manager.cc > File media/audio/audio_manager.cc (right): > ...
5 years, 7 months ago (2015-05-07 18:13:36 UTC) #4
DaleCurtis
On 2015/05/07 18:13:36, watk wrote: > On 2015/05/07 02:11:12, DaleCurtis wrote: > > lgtm > ...
5 years, 7 months ago (2015-05-07 18:31:08 UTC) #5
watk
Turns out nothing breaks if we use STA, so converted to it! Thanks
5 years, 7 months ago (2015-05-13 23:16:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130753005/20001
5 years, 7 months ago (2015-05-14 20:13:47 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 20:24:33 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 20:26:20 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c99b195f6abb12e617e8e14ef95b6403fc504f9f
Cr-Commit-Position: refs/heads/master@{#329917}

Powered by Google App Engine
This is Rietveld 408576698