Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1130753004: virtual keyboard: It is not longer necessary to 'reset' for tests. (Closed)

Created:
5 years, 7 months ago by sadrul
Modified:
5 years, 7 months ago
Reviewers:
oshima, bshe
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

virtual keyboard: It is not longer necessary to 'reset' for tests. The virtual keyboard used to install a WebUIControllerFactory during initialization, and it was necessary to reset the initialization state for the keyboard so that it could reinstall the factory for each test. But the virtual keyboard no longer uses webui. So remove the reset function. BUG=none Committed: https://crrev.com/7486759b94d87eb987a89b4314939e80b8900307 Cr-Commit-Position: refs/heads/master@{#328561}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M ash/test/ash_test_helper.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/keyboard/keyboard.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sadrul
+bshe@ for ui/keyboard/ +oshima@ for ash/
5 years, 7 months ago (2015-05-06 17:14:31 UTC) #2
bshe
On 2015/05/06 17:14:31, sadrul wrote: > +bshe@ for ui/keyboard/ > > +oshima@ for ash/ ui/keyboard ...
5 years, 7 months ago (2015-05-06 17:16:23 UTC) #3
oshima
lgtm
5 years, 7 months ago (2015-05-06 17:20:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130753004/20001
5 years, 7 months ago (2015-05-06 17:25:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-06 18:27:25 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 18:28:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7486759b94d87eb987a89b4314939e80b8900307
Cr-Commit-Position: refs/heads/master@{#328561}

Powered by Google App Engine
This is Rietveld 408576698