Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1130753002: [components/policy] Use ThreadTaskRunnerHandle instead of LoopProxy (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in components/policy module. MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Committed: https://crrev.com/8956bcd3f54895359c610eccf9b5e87626035f53 Cr-Commit-Position: refs/heads/master@{#329386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M components/policy/core/browser/url_blacklist_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/policy/core/common/async_policy_provider.h View 2 chunks +6 lines, -5 lines 0 comments Download
M components/policy/core/common/async_policy_provider.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_service.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Pranay
Hi Erik, PTAL, Thanks
5 years, 7 months ago (2015-05-06 12:29:24 UTC) #2
erikwright (departed)
Please select an owner from https://code.google.com/p/chromium/codesearch#chromium/src/components/policy/OWNERS&sq=package:chromium
5 years, 7 months ago (2015-05-11 18:30:06 UTC) #4
Pranay
On 2015/05/11 18:30:06, erikwright wrote: > Please select an owner from > https://code.google.com/p/chromium/codesearch#chromium/src/components/policy/OWNERS&sq=package:chromium Sure Erik ...
5 years, 7 months ago (2015-05-12 02:48:17 UTC) #5
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-12 02:48:41 UTC) #7
bartfab (slow)
LGTM
5 years, 7 months ago (2015-05-12 08:36:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130753002/1
5 years, 7 months ago (2015-05-12 09:41:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 10:19:58 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 10:21:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8956bcd3f54895359c610eccf9b5e87626035f53
Cr-Commit-Position: refs/heads/master@{#329386}

Powered by Google App Engine
This is Rietveld 408576698