cipd: Add -tag option to 'create' and 'pkg-register' subcomands.

go/src/infra/tools/cipd/uploader.go

Index: go/src/infra/tools/cipd/uploader.go
diff --git a/go/src/infra/tools/cipd/uploader.go b/go/src/infra/tools/cipd/uploader.go
index 78b83dcc3107f1a92f467d512a09c4892a4bfad8..5cc60629a6e0a45350fe37385b9f97ecf090b9e1 100644
--- a/go/src/infra/tools/cipd/uploader.go
+++ b/go/src/infra/tools/cipd/uploader.go
@@ -18,6 +18,8 @@ import (
 var (
 	// ErrFinalizationTimeout is returned if CAS service can not finalize upload fast enough.
 	ErrFinalizationTimeout = errors.New("Timeout while waiting for CAS service to finalize the upload")
+	// ErrAttachTagsTimeout is returned when service refuses to accept tags for a long time.
+	ErrAttachTagsTimeout = errors.New("Timeout while attaching tags")
 )
 
 // UploadOptions contains upload related parameters shared by UploadToCAS and
@@ -135,8 +137,11 @@ func UploadToCAS(options UploadToCASOptions) error {
 type RegisterInstanceOptions struct {
 	UploadOptions
 
-	// PackageInstance is a package to upload.
+	// PackageInstance is a package instance to register.
 	PackageInstance PackageInstance
+	// Tags is a list of tags to attach to an instance. Will be attached even if
+	// instance already existed before.

[nodir, 2015/05/07 04:19:02]

english: the instance

[Vadim Sh., 2015/05/07 05:07:58]

Done.

+	Tags []string
 }
 
 // RegisterInstance makes the package instance available for clients by
@@ -194,7 +199,7 @@ func RegisterInstance(options RegisterInstanceOptions) error {
 		log.Infof("cipd: instance %s:%s was successfully registered", inst.PackageName(), inst.InstanceID())
 	}
 
-	return nil
+	return attachTagsWhenReady(remote, inst.PackageName(), inst.InstanceID(), options.Tags, log)
 }
 
 ////////////////////////////////////////////////////////////////////////////////
@@ -324,3 +329,34 @@ func getNextOffset(uploadURL string, length int64, client *http.Client) (offset
 	}
 	return
 }
+
+////////////////////////////////////////////////////////////////////////////////
+// Tags related functions.
+
+// attachTagsWhenReady attaches tags to an instance retrying when receiving
+// PROCESSING_NOT_FINISHED_YET errors.
+func attachTagsWhenReady(remote *remoteService, packageName, instanceID string, tags []string, log logging.Logger) error {
+	if len(tags) == 0 {
+		return nil
+	}
+	for _, tag := range tags {
+		log.Infof("cipd: attaching tag %s", tag)
+	}
+	deadline := clock.Now().Add(60 * time.Second)
+	for clock.Now().Before(deadline) {
+		err := remote.attachTags(packageName, instanceID, tags)
+		if err == nil {
+			log.Infof("cipd: all tags attached")
+			return nil
+		}
+		if _, ok := err.(*pendingProcessingError); ok {
+			log.Warningf("cipd: package instance is not ready yet - %s", err)
+			clock.Sleep(5 * time.Second)
+		} else {
+			log.Errorf("cipd: failed to attach tags - %s", err)
+			return err
+		}
+	}
+	log.Errorf("cipd: failed to attach tags - deadline exceeded")
+	return ErrAttachTagsTimeout
+}