Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: content/renderer/accessibility/blink_ax_enum_conversion.cc

Issue 1130733006: Adds color, font size, text direction and text styles to the accessibility tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed compilation error. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/accessibility/blink_ax_enum_conversion.cc
diff --git a/content/renderer/accessibility/blink_ax_enum_conversion.cc b/content/renderer/accessibility/blink_ax_enum_conversion.cc
index 10e23889843115d8c11b0d55937c94832570461d..bf2966543bd7aa9a4e719e89a324883d94bfbafb 100644
--- a/content/renderer/accessibility/blink_ax_enum_conversion.cc
+++ b/content/renderer/accessibility/blink_ax_enum_conversion.cc
@@ -392,14 +392,16 @@ ui::AXEvent AXEventFromBlink(blink::WebAXEvent event) {
ui::AXTextDirection AXTextDirectionFromBlink(
blink::WebAXTextDirection text_direction) {
switch (text_direction) {
+ case blink::WebAXTextDirectionUnknown:
+ return ui::AX_TEXT_DIRECTION_NONE;
case blink::WebAXTextDirectionLR:
- return ui::AX_TEXT_DIRECTION_LR;
+ return ui::AX_TEXT_DIRECTION_LTR;
case blink::WebAXTextDirectionRL:
- return ui::AX_TEXT_DIRECTION_RL;
+ return ui::AX_TEXT_DIRECTION_RTL;
case blink::WebAXTextDirectionTB:
- return ui::AX_TEXT_DIRECTION_TB;
+ return ui::AX_TEXT_DIRECTION_TTB;
case blink::WebAXTextDirectionBT:
- return ui::AX_TEXT_DIRECTION_BT;
+ return ui::AX_TEXT_DIRECTION_BTT;
default:
NOTREACHED();
}
@@ -407,6 +409,25 @@ ui::AXTextDirection AXTextDirectionFromBlink(
return ui::AX_TEXT_DIRECTION_NONE;
}
+ui::AXTextStyle AXTextStyleFromBlink(blink::WebAXTextStyle text_style) {
+ switch (text_style) {
+ case blink::WebAXTextStyleNone:
sgurun-gerrit only 2015/05/12 20:11:58 no member named 'WebAXTextDirectionUnknown' in nam
+ return ui::AX_TEXT_STYLE_NONE;
+ case blink::WebAXTextStyleBold:
+ return ui::AX_TEXT_STYLE_BOLD;
+ case blink::WebAXTextStyleItalic:
+ return ui::AX_TEXT_STYLE_ITALIC;
+ case blink::WebAXTextStyleUnderline:
+ return ui::AX_TEXT_STYLE_UNDERLINE;
dmazzoni 2015/05/12 18:34:48 I just realized, these shouldn't be mutually exclu
+ case blink::WebAXTextStyleLineThrough:
+ return ui::AX_TEXT_STYLE_LINE_THROUGH;
+ default:
+ NOTREACHED();
+ }
+
+ return ui::AX_TEXT_STYLE_NONE;
+}
+
ui::AXInvalidState AXInvalidStateFromBlink(
blink::WebAXInvalidState invalid_state) {
switch (invalid_state) {

Powered by Google App Engine
This is Rietveld 408576698