Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1130723002: Ship string unicode escapes (Closed)

Created:
5 years, 7 months ago by rossberg
Modified:
5 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship string unicode escapes R=yangguo@chromium.org BUG= Committed: https://crrev.com/272818d7ff0f049ce25d563fce00d0271a367022 Cr-Commit-Position: refs/heads/master@{#28256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/flag-definitions.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rossberg
5 years, 7 months ago (2015-05-06 11:39:57 UTC) #1
Yang
On 2015/05/06 11:39:57, rossberg wrote: lgtm.
5 years, 7 months ago (2015-05-06 11:41:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130723002/1
5 years, 7 months ago (2015-05-06 11:44:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 12:07:57 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 12:08:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/272818d7ff0f049ce25d563fce00d0271a367022
Cr-Commit-Position: refs/heads/master@{#28256}

Powered by Google App Engine
This is Rietveld 408576698