Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: ios/chrome/browser/dom_distiller/distiller_viewer.h

Issue 1130703003: Show template before distiller finishes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ios-superclass
Patch Set: Fix flaky test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/dom_distiller_strings.grdp ('k') | ios/chrome/browser/dom_distiller/distiller_viewer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/dom_distiller/distiller_viewer.h
diff --git a/ios/chrome/browser/dom_distiller/distiller_viewer.h b/ios/chrome/browser/dom_distiller/distiller_viewer.h
index 629e74546153252eaf6fdaac5ead71140fcb8cc1..1cb4f843001325a9e871f33e36eca6e634b206a6 100644
--- a/ios/chrome/browser/dom_distiller/distiller_viewer.h
+++ b/ios/chrome/browser/dom_distiller/distiller_viewer.h
@@ -34,17 +34,18 @@ class DistillerViewer : public DomDistillerRequestViewBase {
const DistillationFinishedCallback& callback);
~DistillerViewer() override;
- void SendJavaScript(const std::string& buffer) override;
+ void OnArticleReady(
+ const dom_distiller::DistilledArticleProto* article_proto) override;
- std::string GetJavaScriptBuffer();
+ void SendJavaScript(const std::string& buffer) override;
private:
// The url of the distilled page.
const GURL url_;
- // Interface for accessing preferences for distilled pages.
- scoped_ptr<DistilledPagePrefs> distilled_page_prefs_;
// JavaScript buffer.
std::string js_buffer_;
+ // Callback to run once distillation is complete.
+ const DistillationFinishedCallback callback_;
DISALLOW_COPY_AND_ASSIGN(DistillerViewer);
};
« no previous file with comments | « components/dom_distiller_strings.grdp ('k') | ios/chrome/browser/dom_distiller/distiller_viewer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698