Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: components/dom_distiller/core/viewer.h

Issue 1130703003: Show template before distiller finishes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ios-superclass
Patch Set: Fix flaky test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/dom_distiller/core/test_request_view_handle.h ('k') | components/dom_distiller/core/viewer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/dom_distiller/core/viewer.h
diff --git a/components/dom_distiller/core/viewer.h b/components/dom_distiller/core/viewer.h
index 7b9261f5043ac5ddd83037e078222143bab49a09..61b0e4079cfe400c9ea7af951438d89512dfb20f 100644
--- a/components/dom_distiller/core/viewer.h
+++ b/components/dom_distiller/core/viewer.h
@@ -33,7 +33,7 @@ const std::string GetShowFeedbackFormJs();
// considered unsafe, so callers must ensure rendering it does not compromise
// Chrome.
const std::string GetUnsafeArticleTemplateHtml(
- const DistilledPageProto* page_proto,
+ const std::string original_url,
const DistilledPagePrefs::Theme theme,
const DistilledPagePrefs::FontFamily font_family);
@@ -51,6 +51,12 @@ const std::string GetUnsafeIncrementalDistilledPageJs(
const DistilledPageProto* page_proto,
const bool is_last_page);
+// Returns the JavaScript to set the title of the distilled article page.
+const std::string GetSetTitleJs(std::string title);
+
+// Return the JavaScript to set the text direction of the distiller page.
+const std::string GetSetTextDirectionJs(const std::string& direction);
+
// Returns a JavaScript blob for updating a view request with error page
// contents.
const std::string GetErrorPageJs();
@@ -60,11 +66,6 @@ const std::string GetErrorPageJs();
// the last page of the article (i.e. loading indicator should be removed).
const std::string GetToggleLoadingIndicatorJs(const bool is_last_page);
-// Returns a full HTML page which displays a generic error.
-const std::string GetErrorPageHtml(
- const DistilledPagePrefs::Theme theme,
- const DistilledPagePrefs::FontFamily font_family);
-
// Returns the default CSS to be used for a viewer.
const std::string GetCss();
« no previous file with comments | « components/dom_distiller/core/test_request_view_handle.h ('k') | components/dom_distiller/core/viewer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698