Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: components/dom_distiller/core/dom_distiller_request_view_base.h

Issue 1130703003: Show template before distiller finishes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ios-superclass
Patch Set: Fix flaky test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/core/dom_distiller_request_view_base.h
diff --git a/components/dom_distiller/core/dom_distiller_request_view_base.h b/components/dom_distiller/core/dom_distiller_request_view_base.h
index 16b8ca7d93debd0eb6d6a741cea6943cc253495c..ef0fb9f0f8628f38a95e04f94bfa08f0aa1f07e8 100644
--- a/components/dom_distiller/core/dom_distiller_request_view_base.h
+++ b/components/dom_distiller/core/dom_distiller_request_view_base.h
@@ -21,24 +21,13 @@
namespace dom_distiller {
-// This interface is used to abstract the data callback from the distiller. The
-// callbacks for different platforms have different numbers of parameters
-// (namely iOS and Android) which makes this necessary.
-class DistillerDataCallback {
- public:
- virtual ~DistillerDataCallback(){};
- virtual void RunCallback(std::string& data) = 0;
-};
-
// Handles receiving data asynchronously for a specific entry, and passing
// it along to the data callback for the data source. Lifetime matches that of
// the current main frame's page in the Viewer instance.
-class DomDistillerRequestViewBase
- : public ViewRequestDelegate,
- public DistilledPagePrefs::Observer {
+class DomDistillerRequestViewBase : public ViewRequestDelegate,
+ public DistilledPagePrefs::Observer {
public:
explicit DomDistillerRequestViewBase(
- scoped_ptr<DistillerDataCallback> callback,
DistilledPagePrefs* distilled_page_prefs);
~DomDistillerRequestViewBase() override;
@@ -68,9 +57,6 @@ class DomDistillerRequestViewBase
// needs to be kept around to ensure the distillation request finishes.
scoped_ptr<ViewerHandle> viewer_handle_;
- // Holds the callback to where the data retrieved is sent back.
- scoped_ptr<DistillerDataCallback> callback_;
-
// Number of pages of the distilled article content that have been rendered by
// the viewer.
int page_count_;
« no previous file with comments | « components/dom_distiller/core/BUILD.gn ('k') | components/dom_distiller/core/dom_distiller_request_view_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698