Show template before distiller finishes

components/dom_distiller/content/distiller_page_web_contents_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/weak_ptr.h"
 #include "base/path_service.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "components/dom_distiller/content/distiller_page_web_contents.h"
@@ skipping 413 matching lines @@
 
   const proto::MarkupImage markup_image2 = markup_info.images(1);
   EXPECT_EQ("http://test/markup2.gif", markup_image2.url());
   EXPECT_EQ("https://test/markup2.gif", markup_image2.secure_url());
   EXPECT_EQ("gif", markup_image2.type());
   EXPECT_EQ("", markup_image2.caption());
   EXPECT_EQ(1000, markup_image2.width());
   EXPECT_EQ(600, markup_image2.height());
 }
 
-IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest, TestTitleNeverEmpty) {
-  const std::string some_title = "some title";
-  const std::string no_title =
-      l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_NO_DATA_TITLE);
-
-  {  // Test empty title for article.
-    scoped_ptr<DistilledArticleProto> article_proto(
-        new DistilledArticleProto());
-    article_proto->set_title("");
-    (*(article_proto->add_pages())).set_html("");
-    std::string html = viewer::GetUnsafeArticleTemplateHtml(
-        &article_proto.get()->pages(0), DistilledPagePrefs::LIGHT,
-        DistilledPagePrefs::SERIF);
-    EXPECT_THAT(html, HasSubstr(no_title));
-    EXPECT_THAT(html, Not(HasSubstr(some_title)));
-  }
-
-  {  // Test empty title for page.
-    scoped_ptr<DistilledPageProto> page_proto(new DistilledPageProto());
-    page_proto->set_title("");
-    page_proto->set_html("");
-    std::string html = viewer::GetUnsafeArticleTemplateHtml(
-        page_proto.get(), DistilledPagePrefs::LIGHT, DistilledPagePrefs::SERIF);
-    EXPECT_THAT(html, HasSubstr(no_title));
-    EXPECT_THAT(html, Not(HasSubstr(some_title)));
-  }
-
-  {  // Test missing title for page.
-    scoped_ptr<DistilledPageProto> page_proto(new DistilledPageProto());
-    std::string html = viewer::GetUnsafeArticleTemplateHtml(
-        page_proto.get(), DistilledPagePrefs::LIGHT, DistilledPagePrefs::SERIF);
-    EXPECT_THAT(html, HasSubstr(no_title));
-    EXPECT_THAT(html, Not(HasSubstr(some_title)));
-  }
-}
-
 IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest,
                        TestNoContentDoesNotCrash) {
   const std::string no_content =
       l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_NO_DATA_CONTENT);
 
   {  // Test zero pages.
     scoped_ptr<DistilledArticleProto> article_proto(
         new DistilledArticleProto());
     std::string js = viewer::GetUnsafeArticleContentJs(article_proto.get());
     EXPECT_THAT(js, HasSubstr(no_content));
@@ skipping 38 matching lines @@
   ASSERT_TRUE(js_result_);
   ASSERT_TRUE(js_result_->GetAsDictionary(&dict));
 
   ASSERT_TRUE(dict->HasKey("success"));
   bool success;
   ASSERT_TRUE(dict->GetBoolean("success", &success));
   EXPECT_TRUE(success);
 }
 
 }  // namespace dom_distiller