Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1130673004: Add start, stop, restart buttons to sksysmon. (Closed)

Created:
5 years, 7 months ago by jcgregorio
Modified:
5 years, 7 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add start, stop, restart buttons to sksysmon. Screenshot: https://screenshot.googleplex.com/HgzwQcHvJQk.png BUG=skia: TBR=rmistry Committed: https://skia.googlesource.com/buildbot/+/845e8efcf9c220df68394c14a57e2f2fbda09e78

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -13 lines) Patch
M sksysmon/elements.html View 1 chunk +1 line, -0 lines 0 comments Download
M sksysmon/go/sksysmon/main.go View 1 2 3 4 chunks +68 lines, -0 lines 0 comments Download
M sksysmon/res/imp/unitlist.html View 1 2 chunks +41 lines, -5 lines 0 comments Download
M sksysmon/templates/index.html View 1 chunk +13 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jcgregorio
5 years, 7 months ago (2015-05-15 18:45:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130673004/50001
5 years, 7 months ago (2015-05-17 13:17:25 UTC) #4
jcgregorio
Landing TBR because I want to try porting this to Polymer 0.9.
5 years, 7 months ago (2015-05-17 13:17:36 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:50001) as https://skia.googlesource.com/buildbot/+/845e8efcf9c220df68394c14a57e2f2fbda09e78
5 years, 7 months ago (2015-05-17 13:18:48 UTC) #6
rmistry
5 years, 7 months ago (2015-05-18 12:45:08 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698