Remove the removed display from the active list after displays are added

ash/display/display_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/display/display_manager.h"
 
 #include "ash/ash_switches.h"
 #include "ash/display/display_controller.h"
 #include "ash/display/display_info.h"
 #include "ash/display/display_layout_store.h"
 #include "ash/display/display_util.h"
 #include "ash/display/mirror_window_controller.h"
 #include "ash/screen_util.h"
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/test/display_manager_test_api.h"
 #include "ash/test/mirror_window_test_api.h"
+#include "ash/wm/window_state.h"
 #include "base/command_line.h"
 #include "base/format_macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
+#include "ui/aura/client/aura_constants.h"
 #include "ui/aura/env.h"
 #include "ui/aura/window_observer.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/events/test/event_generator.h"
 #include "ui/gfx/display.h"
 #include "ui/gfx/display_observer.h"
 #include "ui/gfx/font_render_params.h"
 #include "ui/gfx/screen.h"
 #include "ui/gfx/screen_type_delegate.h"
 
@@ skipping 1473 matching lines @@
                                         gfx::Display::ROTATION_SOURCE_ACTIVE);
   EXPECT_EQ("500x700", screen->GetPrimaryDisplay().size().ToString());
   display_manager()->SetDisplayRotation(display.id(), gfx::Display::ROTATE_0,
                                         gfx::Display::ROTATION_SOURCE_ACTIVE);
   EXPECT_EQ("700x500", screen->GetPrimaryDisplay().size().ToString());
 
   UpdateDisplay("300x200");
   EXPECT_EQ("300x200", screen->GetPrimaryDisplay().size().ToString());
 }
 
+// Makes sure the transition from unified to single won't crash
+// with docked wnidows.
+TEST_F(DisplayManagerTest, UnifiedWithDockWindows) {
+  if (!SupportsMultipleDisplays())
+    return;
+
+  display_manager()->SetDefaultMultiDisplayMode(DisplayManager::UNIFIED);
+  display_manager()->SetMultiDisplayMode(DisplayManager::UNIFIED);
+  UpdateDisplay("300x200,400x500");
+
+  scoped_ptr<aura::Window> docked(
+      CreateTestWindowInShellWithBounds(gfx::Rect(10, 10, 50, 50)));
+  docked->SetProperty(aura::client::kShowStateKey, ui::SHOW_STATE_DOCKED);
+  ASSERT_TRUE(wm::GetWindowState(docked.get())->IsDocked());
+  EXPECT_EQ("0,0 250x453", docked->bounds().ToString());
+  UpdateDisplay("300x200");
+  // Make sure the window is still docked.
+  EXPECT_TRUE(wm::GetWindowState(docked.get())->IsDocked());
+  EXPECT_EQ("0,0 250x250", docked->bounds().ToString());
+}
+
 class ScreenShutdownTest : public test::AshTestBase {
  public:
   ScreenShutdownTest() {
   }
   ~ScreenShutdownTest() override {}
 
   void TearDown() override {
     gfx::Screen* orig_screen =
         gfx::Screen::GetScreenByType(gfx::SCREEN_TYPE_ALTERNATE);
     AshTestBase::TearDown();
@@ skipping 141 matching lines @@
       1.25f, Shell::GetScreen()->GetPrimaryDisplay().device_scale_factor());
   EXPECT_TRUE(IsTextSubpixelPositioningEnabled());
   EXPECT_EQ(gfx::FontRenderParams::HINTING_NONE, GetFontHintingParams());
 
   DisplayInfo::SetUse125DSFForUIScaling(false);
 }
 
 #endif  // OS_CHROMEOS
 
 }  // namespace ash