Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1130653004: Remove the removed display from the active list after displays are added (Closed)

Created:
5 years, 7 months ago by oshima
Modified:
5 years, 7 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the removed display from the active list after displays are added. This is necessary because the unified display is needed to move the windows to new, normal display. Fix DisplayManagerTestApi::UpdateDisplays so that unified display isn't used for extended mode. BUG=487368 TEST=covered by test. Committed: https://crrev.com/01fadba93bdebd1c535f13e56c85722c1fa287cb Cr-Commit-Position: refs/heads/master@{#329675}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -12 lines) Patch
M ash/display/display_manager.cc View 1 1 chunk +7 lines, -9 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 2 chunks +23 lines, -0 lines 0 comments Download
M ash/test/display_manager_test_api.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
oshima
5 years, 7 months ago (2015-05-13 02:14:51 UTC) #2
Jun Mukai
lgtm
5 years, 7 months ago (2015-05-13 17:47:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130653004/20001
5 years, 7 months ago (2015-05-13 17:50:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 17:57:06 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 17:57:59 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01fadba93bdebd1c535f13e56c85722c1fa287cb
Cr-Commit-Position: refs/heads/master@{#329675}

Powered by Google App Engine
This is Rietveld 408576698