chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 1130603005: [PermissionBubble] Remove bubble from previous manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 1130603005: [PermissionBubble] Remove bubble from previous manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Managers can be NULL at shutdown - account for that. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index 5a70b3940eb34aa55558cbb459fa827e4839395a..dab05bbc6830c476ee1f9f8c2f5e1b14c6260638 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -330,11 +330,13 @@ void BrowserWindowCocoa::OnActiveTabChanged(content::WebContents* old_contents,

content::WebContents* new_contents,

int index,

int reason) {

+ [controller_ onActiveTabChanged:old_contents to:new_contents];

// TODO(pkasting): Perhaps the code in

// TabStripController::activateTabWithContents should move here? Or this

// should call that (instead of TabStripModelObserverBridge doing so)? It's

// not obvious to me why Mac doesn't handle tab changes in BrowserWindow the

// way views and GTK do.

+ // See http://crbug.com/340720 for discussion.

}

void BrowserWindowCocoa::ZoomChangedForActiveTab(bool can_show_bubble) {

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_controller.h » ('j') | chrome/browser/ui/cocoa/browser_window_controller.mm » ('J')