Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Issue 1130603004: PPC: Fix '[strong] Disallow implicit conversions for comparison' (Closed)

Created:
5 years, 7 months ago by MTBrandyberry
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Fix '[strong] Disallow implicit conversions for comparison' Fix build break. R=conradw@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/174242fbbe86014c84f4619805a15c869b44a96d Cr-Commit-Position: refs/heads/master@{#28374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 7 months ago (2015-05-12 16:00:53 UTC) #1
dstence
lgtm
5 years, 7 months ago (2015-05-12 16:19:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130603004/1
5 years, 7 months ago (2015-05-12 16:20:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 16:43:31 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 16:43:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/174242fbbe86014c84f4619805a15c869b44a96d
Cr-Commit-Position: refs/heads/master@{#28374}

Powered by Google App Engine
This is Rietveld 408576698