Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1130603002: Fix suppression for WindowProxy::initializeIfNeeded to match on release builds. (Closed)

Created:
5 years, 7 months ago by alexmos
Modified:
5 years, 7 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix suppression for WindowProxy::initializeIfNeeded to match on release builds. Due to 484760, symbolization for WindowProxy::initializeIfNeeded is different between debug and release builds, which causes the current suppression to not match on the try bots. On release builds, it comes up as: > #8 0x7875c74 in initializeIfNeeded third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:209:19 Use blink::WindowProxy::createContext instead. BUG=484760, 478792 NOTRY=true Committed: https://crrev.com/8c214f63c675d641c31053ebd1c56688e774f557 Cr-Commit-Position: refs/heads/master@{#328447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/sanitizers/lsan_suppressions.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
alexmos
5 years, 7 months ago (2015-05-06 00:13:09 UTC) #2
Zhenyao Mo
On 2015/05/06 00:13:09, alexmos wrote: LGTM Please land using TBR so we get the roll ...
5 years, 7 months ago (2015-05-06 00:14:04 UTC) #3
Zhenyao Mo
I mean NOTRY=true
5 years, 7 months ago (2015-05-06 00:14:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130603002/1
5 years, 7 months ago (2015-05-06 00:17:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 00:23:20 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 00:25:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c214f63c675d641c31053ebd1c56688e774f557
Cr-Commit-Position: refs/heads/master@{#328447}

Powered by Google App Engine
This is Rietveld 408576698