Issue 1130563002: Moterm part 1: Add MotermModel, a "model" for terminal emulation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1130563002: Moterm part 1: Add MotermModel, a "model" for terminal emulation. (Closed)

Created:
5 years, 7 months ago by viettrungluu

Modified:
5 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Moterm part 1: Add MotermModel, a "model" for terminal emulation. This currently wraps libteken, but abstracts this dependency away. R=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/36627ffa51c64341abff07f0945da6a478514176

Patch Set 1 #

Patch Set 2 : oops #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+796 lines, -0 lines)			Patch
M	BUILD.gn	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A +	apps/BUILD.gn	View		1 chunk	+8 lines, -0 lines	0 comments	Download
A	apps/moterm/BUILD.gn	View		1 chunk	+39 lines, -0 lines	0 comments	Download
A	apps/moterm/moterm_model.h	View		1 chunk	+178 lines, -0 lines	0 comments	Download
A	apps/moterm/moterm_model.cc	View		1 chunk	+364 lines, -0 lines	0 comments	Download
A	apps/moterm/moterm_model_unittest.cc	View		1 chunk	+203 lines, -0 lines	0 comments	Download
M	mojo/tools/data/apptests	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

5 years, 7 months ago (2015-05-11 19:36:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
36627ffa51c64341abff07f0945da6a478514176 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages