Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1130523003: Add support for escaped target names in isolate driver (3rd try) (Closed)

Created:
5 years, 7 months ago by nyquist
Modified:
5 years, 5 months ago
Reviewers:
Vadim Sh., Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for escaped target names in isolate driver (3rd try) Currently the isolate_driver.py which creates the dependency files used by the isolate system, does a simple split on all spaces when trying to identify targets. This can fail if the target name contains a space in the name. In ninja, spaces are escaped with a $-prefix. An example would be 'Content$ Shell$ Helper.app'. This CL adds support for such target names and ensures that they stay as one item. Doing this uncovered a few missing dependencies and a missing file in some .isolate-files for the component build on Mac. 1st try: https://codereview.chromium.org/970203003/ 1st revert: https://codereview.chromium.org/985753002/ 2nd try: https://codereview.chromium.org/1103793002/ 2nd revert: https://codereview.chromium.org/1129493003/ BUG=462248 Committed: https://crrev.com/e94fb8bb82056ce3a255691a9326fd12707cf0cb Cr-Commit-Position: refs/heads/master@{#329038}

Patch Set 1 : Revert of revert #

Patch Set 2 : Add inclusion of chrome.isolate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/chrome.isolate View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/sync_integration_tests.isolate View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/isolate_driver.py View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130523003/20001
5 years, 7 months ago (2015-05-05 20:43:34 UTC) #2
nyquist
thakis: PTAL (added chrome.isolate inclusion) vadimsh: PTAL (same as before)
5 years, 7 months ago (2015-05-05 21:58:08 UTC) #4
Vadim Sh.
lgtm
5 years, 7 months ago (2015-05-05 22:02:26 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-05 22:10:00 UTC) #7
nyquist
thakis: friendly ping
5 years, 7 months ago (2015-05-07 23:47:18 UTC) #8
Nico
lgtm
5 years, 7 months ago (2015-05-08 20:33:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130523003/20001
5 years, 7 months ago (2015-05-08 20:36:42 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-09 04:18:15 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e94fb8bb82056ce3a255691a9326fd12707cf0cb Cr-Commit-Position: refs/heads/master@{#329038}
5 years, 7 months ago (2015-05-09 04:19:00 UTC) #13
Nico
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1131363003/ by thakis@chromium.org. ...
5 years, 7 months ago (2015-05-10 16:29:32 UTC) #14
rmistry
5 years, 7 months ago (2015-05-10 18:13:29 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1137953002/ by rmistry@google.com.

The reason for reverting is: Testing time taken to revert. Please ignore..

Powered by Google App Engine
This is Rietveld 408576698