Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2043)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 11305008: Remove TabContents from TabStripModelObserverBridge. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: no crashes Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/base_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/hung_renderer_controller.mm » ('j') | chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 5bf5d07407aace99a8e9ce0e97008f686b7457f3..8da07103d9fb5e2466cfc8e2449d679d8c958935 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1551,9 +1551,7 @@ enum {
// applicable)?
[self updateBookmarkBarVisibilityWithAnimation:NO];
- TabContents* tabContents = TabContents::FromWebContents(contents);
- // Without the .get(), xcode fails.
- [infoBarContainerController_.get() changeTabContents:tabContents];
+ [infoBarContainerController_ changeWebContents:contents];
}
- (void)onReplaceTabWithContents:(WebContents*)contents {
@@ -1580,8 +1578,7 @@ enum {
}
- (void)onTabDetachedWithContents:(WebContents*)contents {
- TabContents* tabContents = TabContents::FromWebContents(contents);
- [infoBarContainerController_ tabDetachedWithContents:tabContents];
+ [infoBarContainerController_ tabDetachedWithContents:contents];
}
- (void)onInsertTabWithContents:(WebContents*)contents {
« no previous file with comments | « chrome/browser/ui/cocoa/base_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/hung_renderer_controller.mm » ('j') | chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698