gin/shell_runner_unittest.cc - Issue 1130433002: Adding task runner/ message loop to tests that use IsolateHolder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/shell_runner_unittest.cc

Issue 1130433002: Adding task runner/ message loop to tests that use IsolateHolder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing mac build. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/shell_runner_unittest.cc

diff --git a/gin/shell_runner_unittest.cc b/gin/shell_runner_unittest.cc

index 340b673362f44dbc5e9155374d1d2386af9a9354..4e4b9c2fa9cff54374c6bfbd6b7a0a317fb3ea5e 100644

--- a/gin/shell_runner_unittest.cc

+++ b/gin/shell_runner_unittest.cc

@@ -5,6 +5,7 @@

#include "gin/shell_runner.h"

#include "base/compiler_specific.h"

+#include "base/message_loop/message_loop.h"

#include "gin/array_buffer.h"

#include "gin/converter.h"

#include "gin/public/isolate_holder.h"

@@ -23,6 +24,7 @@ using v8::String;

namespace gin {

TEST(RunnerTest, Run) {

+ base::MessageLoop message_loop;

std::string source = "this.result = 'PASS';\n";

#ifdef V8_USE_EXTERNAL_STARTUP_DATA

« no previous file with comments | « gin/modules/timer_unittest.cc ('k') | gin/test/v8_test.h » ('j') | no next file with comments »