gin/modules/module_registry_unittest.cc - Issue 1130433002: Adding task runner/ message loop to tests that use IsolateHolder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/modules/module_registry_unittest.cc

Issue 1130433002: Adding task runner/ message loop to tests that use IsolateHolder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing mac build. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/modules/module_registry_unittest.cc

diff --git a/gin/modules/module_registry_unittest.cc b/gin/modules/module_registry_unittest.cc

index 2d6e6daf83eb1eba0b76c5e93f2f2a1a4dea7db7..00c6a94e1939ae4936245850daebe7c2f1ba019f 100644

--- a/gin/modules/module_registry_unittest.cc

+++ b/gin/modules/module_registry_unittest.cc

@@ -5,7 +5,6 @@

#include "gin/modules/module_registry.h"

#include "base/bind.h"

-#include "base/message_loop/message_loop.h"

#include "gin/modules/module_registry_observer.h"

#include "gin/modules/module_runner_delegate.h"

#include "gin/public/context_holder.h"

@@ -25,7 +24,6 @@ struct TestHelper {

scope(runner.get()) {

}

- base::MessageLoop message_loop;

ModuleRunnerDelegate delegate;

scoped_ptr<ShellRunner> runner;

Runner::Scope scope;

« no previous file with comments | « gin/converter_unittest.cc ('k') | gin/modules/timer_unittest.cc » ('j') | no next file with comments »