Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gin/shell_runner_unittest.cc

Issue 1130433002: Adding task runner/ message loop to tests that use IsolateHolder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/test/test_blink_web_unit_test_support.cc ('K') | « gin/modules/timer_unittest.cc ('k') | gin/test/v8_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/shell_runner_unittest.cc
diff --git a/gin/shell_runner_unittest.cc b/gin/shell_runner_unittest.cc
index 340b673362f44dbc5e9155374d1d2386af9a9354..4e4b9c2fa9cff54374c6bfbd6b7a0a317fb3ea5e 100644
--- a/gin/shell_runner_unittest.cc
+++ b/gin/shell_runner_unittest.cc
@@ -5,6 +5,7 @@
#include "gin/shell_runner.h"
#include "base/compiler_specific.h"
+#include "base/message_loop/message_loop.h"
#include "gin/array_buffer.h"
#include "gin/converter.h"
#include "gin/public/isolate_holder.h"
@@ -23,6 +24,7 @@ using v8::String;
namespace gin {
TEST(RunnerTest, Run) {
+ base::MessageLoop message_loop;
std::string source = "this.result = 'PASS';\n";
#ifdef V8_USE_EXTERNAL_STARTUP_DATA
« content/test/test_blink_web_unit_test_support.cc ('K') | « gin/modules/timer_unittest.cc ('k') | gin/test/v8_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698