Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: gin/test/v8_test.h

Issue 1130433002: Adding task runner/ message loop to tests that use IsolateHolder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gin/modules/timer_unittest.cc ('K') | « gin/shell_runner_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/test/v8_test.h
diff --git a/gin/test/v8_test.h b/gin/test/v8_test.h
index e9209ce97921fb17333382092b754b7ebc79970b..439518d273eb2ca3ca91c0a32762cbf4d9f3e713 100644
--- a/gin/test/v8_test.h
+++ b/gin/test/v8_test.h
@@ -8,6 +8,7 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "v8/include/v8.h"
@@ -28,6 +29,7 @@ class V8Test : public testing::Test {
protected:
scoped_ptr<IsolateHolder> instance_;
v8::Persistent<v8::Context> context_;
+ base::MessageLoop message_loop;
Sami 2015/05/05 15:10:26 Please move this first since I'm guess this should
ssid 2015/05/05 16:00:06 Done.
private:
DISALLOW_COPY_AND_ASSIGN(V8Test);
« gin/modules/timer_unittest.cc ('K') | « gin/shell_runner_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698