Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: gin/modules/module_registry_unittest.cc

Issue 1130433002: Adding task runner/ message loop to tests that use IsolateHolder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/modules/module_registry_unittest.cc
diff --git a/gin/modules/module_registry_unittest.cc b/gin/modules/module_registry_unittest.cc
index 2d6e6daf83eb1eba0b76c5e93f2f2a1a4dea7db7..00c6a94e1939ae4936245850daebe7c2f1ba019f 100644
--- a/gin/modules/module_registry_unittest.cc
+++ b/gin/modules/module_registry_unittest.cc
@@ -5,7 +5,6 @@
#include "gin/modules/module_registry.h"
#include "base/bind.h"
-#include "base/message_loop/message_loop.h"
#include "gin/modules/module_registry_observer.h"
#include "gin/modules/module_runner_delegate.h"
#include "gin/public/context_holder.h"
@@ -25,7 +24,6 @@ struct TestHelper {
scope(runner.get()) {
}
- base::MessageLoop message_loop;
Sami 2015/05/05 13:55:54 Why did we need to remove this?
ssid 2015/05/05 16:00:06 This is removed from here because we already initi
ModuleRunnerDelegate delegate;
scoped_ptr<ShellRunner> runner;
Runner::Scope scope;

Powered by Google App Engine
This is Rietveld 408576698