Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: gin/test/v8_test.h

Issue 1130433002: Adding task runner/ message loop to tests that use IsolateHolder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« gin/modules/timer_unittest.cc ('K') | « gin/shell_runner_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_TEST_V8_TEST_H_ 5 #ifndef GIN_TEST_V8_TEST_H_
6 #define GIN_TEST_V8_TEST_H_ 6 #define GIN_TEST_V8_TEST_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/message_loop/message_loop.h"
11 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
12 #include "v8/include/v8.h" 13 #include "v8/include/v8.h"
13 14
14 namespace gin { 15 namespace gin {
15 16
16 class IsolateHolder; 17 class IsolateHolder;
17 18
18 // V8Test is a simple harness for testing interactions with V8. V8Test doesn't 19 // V8Test is a simple harness for testing interactions with V8. V8Test doesn't
19 // have any dependencies on Gin's module system. 20 // have any dependencies on Gin's module system.
20 class V8Test : public testing::Test { 21 class V8Test : public testing::Test {
21 public: 22 public:
22 V8Test(); 23 V8Test();
23 ~V8Test() override; 24 ~V8Test() override;
24 25
25 void SetUp() override; 26 void SetUp() override;
26 void TearDown() override; 27 void TearDown() override;
27 28
28 protected: 29 protected:
29 scoped_ptr<IsolateHolder> instance_; 30 scoped_ptr<IsolateHolder> instance_;
30 v8::Persistent<v8::Context> context_; 31 v8::Persistent<v8::Context> context_;
32 base::MessageLoop message_loop;
Sami 2015/05/05 15:10:26 Please move this first since I'm guess this should
ssid 2015/05/05 16:00:06 Done.
31 33
32 private: 34 private:
33 DISALLOW_COPY_AND_ASSIGN(V8Test); 35 DISALLOW_COPY_AND_ASSIGN(V8Test);
34 }; 36 };
35 37
36 } // namespace gin 38 } // namespace gin
37 39
38 #endif // GIN_TEST_V8_TEST_H_ 40 #endif // GIN_TEST_V8_TEST_H_
OLDNEW
« gin/modules/timer_unittest.cc ('K') | « gin/shell_runner_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698