Adding task runner/ message loop to tests that use IsolateHolder.

gin/modules/timer_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gin/modules/timer.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "gin/handle.h"
 #include "gin/object_template_builder.h"
@@ skipping 47 matching lines @@
         timer_module(TimerModule::Create(isolate)),
         result(Result::Create(isolate)) {
     EXPECT_FALSE(runner->global().IsEmpty());
     runner->global()->Set(StringToV8(isolate, "timer"),
                           timer_module->GetWrapper(isolate));
     runner->global()->Set(StringToV8(isolate, "result"),
                           result->GetWrapper(isolate));
   }
 
   void QuitSoon() {
-    loop.PostDelayedTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),
-                         base::TimeDelta::FromMilliseconds(0));
+    base::MessageLoop::current()->PostDelayedTask(

[Sami, 2015/05/05 13:55:54]

Please use ThreadTaskRunnerHandle::Get() instead of MessageLoop::current() (the
Post*Task functions on MessageLoop are deprecated).

[Primiano Tucci (use gerrit), 2015/05/05 14:26:51]

Is this going to use the DummyTaskRunner? If so, isn't this going to hit the
DCHECK?

[Sami, 2015/05/05 14:35:46]

Actually not, because you can't have both a MessageLoop and a DummyTaskRunner
active at the same time (they both DCHECK that no-one else is using the same TLS
handle).

[ssid, 2015/05/05 16:00:06]

No, this change here is not related to the dummy task runner added. The
TestBlinkWebUnitTestSupport does not use this test suite. This is part of
gin_unittests, which uses real message loop.
I added in same CL since both are fixing tests and doing similar changes.

+        FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),
+        base::TimeDelta::FromMilliseconds(0));
   }
 
   ShellRunnerDelegate delegate;
   scoped_ptr<ShellRunner> runner;
   Runner::Scope scope;
   Handle<TimerModule> timer_module;
   Handle<Result> result;
-  base::MessageLoop loop;
 };
 
 }  // namespace
 
 typedef V8Test TimerUnittest;
 
 TEST_F(TimerUnittest, OneShot) {
   TestHelper helper(instance_->isolate());
   std::string source =
      "timer.createOneShot(0, function() {"
      "  result.count++;"
      "});";
 
   helper.runner->Run(source, "script");
   EXPECT_EQ(0, helper.result->count());
 
   helper.QuitSoon();
-  helper.loop.Run();
+  base::MessageLoop::current()->Run();
   EXPECT_EQ(1, helper.result->count());
 }
 
 TEST_F(TimerUnittest, OneShotCancel) {
   TestHelper helper(instance_->isolate());
   std::string source =
      "var t = timer.createOneShot(0, function() {"
      "  result.count++;"
      "});"
      "t.cancel()";
 
   helper.runner->Run(source, "script");
   EXPECT_EQ(0, helper.result->count());
 
   helper.QuitSoon();
-  helper.loop.Run();
+  base::MessageLoop::current()->Run();
   EXPECT_EQ(0, helper.result->count());
 }
 
 TEST_F(TimerUnittest, Repeating) {
   TestHelper helper(instance_->isolate());
 
   // TODO(aa): Cannot do: if (++result.count == 3) because of v8 bug. Create
   // test case and report.
   std::string source =
      "timer.createRepeating(0, function() {"
      "  result.count++;"
      "  if (result.count == 3) {"
      "    result.quit();"
      "  }"
      "});";
 
   helper.runner->Run(source, "script");
   EXPECT_EQ(0, helper.result->count());
 
-  helper.loop.Run();
+  base::MessageLoop::current()->Run();
   EXPECT_EQ(3, helper.result->count());
 }
 
 TEST_F(TimerUnittest, TimerCallbackToDestroyedRunner) {
   TestHelper helper(instance_->isolate());
   std::string source =
      "timer.createOneShot(0, function() {"
      "  result.count++;"
      "});";
 
   helper.runner->Run(source, "script");
   EXPECT_EQ(0, helper.result->count());
 
   // Destroy runner, which should destroy the timer object we created.
   helper.QuitSoon();
   helper.runner.reset(NULL);
-  helper.loop.Run();
+  base::MessageLoop::current()->Run();
 
   // Timer should not have run because it was deleted.
   EXPECT_EQ(0, helper.result->count());
 }
 
 }  // namespace gin