Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1130423006: Add a "gn path" command for finding deps. (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a "gn path" command for finding deps. This command will find an annotate dependencies between two targets in the tree. I wanted this when tracking down some dependency issues so wrote a tool for it. Committed: https://crrev.com/14769fd8e3bd31bd5f5f59e6d0feb7eaefd51e34 Cr-Commit-Position: refs/heads/master@{#330632}

Patch Set 1 #

Patch Set 2 : better messaging #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -0 lines) Patch
M tools/gn/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A tools/gn/command_path.cc View 1 2 1 chunk +159 lines, -0 lines 2 comments Download
M tools/gn/commands.h View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/gn/commands.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/gn.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
brettw
5 years, 7 months ago (2015-05-18 20:32:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130423006/1
5 years, 7 months ago (2015-05-18 20:32:55 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-18 21:06:46 UTC) #6
Dirk Pranke
This basically looks good. The bazel query language is here: http://bazel.io/docs/query.html It is substantially more ...
5 years, 7 months ago (2015-05-18 21:22:46 UTC) #7
brettw
New patch prints the first by default with a --all option as suggested. I also ...
5 years, 7 months ago (2015-05-19 18:37:04 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130423006/40001
5 years, 7 months ago (2015-05-19 18:37:43 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-19 19:18:58 UTC) #12
Dirk Pranke
https://codereview.chromium.org/1130423006/diff/40001/tools/gn/command_path.cc File tools/gn/command_path.cc (right): https://codereview.chromium.org/1130423006/diff/40001/tools/gn/command_path.cc#newcode59 tools/gn/command_path.cc:59: (*found_count)++; If I'm reading this correctly, this routine will ...
5 years, 7 months ago (2015-05-19 19:43:29 UTC) #13
brettw
https://codereview.chromium.org/1130423006/diff/40001/tools/gn/command_path.cc File tools/gn/command_path.cc (right): https://codereview.chromium.org/1130423006/diff/40001/tools/gn/command_path.cc#newcode59 tools/gn/command_path.cc:59: (*found_count)++; On 2015/05/19 19:43:29, Dirk Pranke wrote: > If ...
5 years, 7 months ago (2015-05-19 21:09:55 UTC) #14
Dirk Pranke
makes sense. I doubt it's all that slow either way. lgtm.
5 years, 7 months ago (2015-05-19 22:00:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130423006/40001
5 years, 7 months ago (2015-05-19 22:16:22 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-19 22:22:36 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 22:24:19 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/14769fd8e3bd31bd5f5f59e6d0feb7eaefd51e34
Cr-Commit-Position: refs/heads/master@{#330632}

Powered by Google App Engine
This is Rietveld 408576698