Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: pkg/analyzer/test/src/context/context_test.dart

Issue 1130423003: Validate modifications times only for sources. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/context/context_test.dart
diff --git a/pkg/analyzer/test/src/context/context_test.dart b/pkg/analyzer/test/src/context/context_test.dart
index bbd033e755f9737f7c44f73196eda0a85fc47917..24899224d66136f098644538729e22aa42780a63 100644
--- a/pkg/analyzer/test/src/context/context_test.dart
+++ b/pkg/analyzer/test/src/context/context_test.dart
@@ -471,7 +471,7 @@ class ClassA {}''');
expect(importNode.source, libSource);
}
- void fail_performAnalysisTask_addPart() {
+ void test_performAnalysisTask_addPart() {
Source libSource = addSource("/lib.dart", r'''
library lib;
part 'part.dart';''');
@@ -910,7 +910,7 @@ int ya = 0;''';
});
}
- void fail_setContents_unchanged_consistentModificationTime() {
+ void test_setContents_unchanged_consistentModificationTime() {
String contents = "// foo";
Source source = addSource("/test.dart", contents);
// do all, no tasks
@@ -1987,18 +1987,9 @@ int a = 0;''');
}
/**
- * Perform analysis tasks up to 512 times and asserts that that was enough.
+ * Perform analysis tasks up to 512 times and assert that it was enough.
*/
- void _analyzeAll_assertFinished() {
- _analyzeAll_assertFinished2(512);
- }
-
- /**
- * Perform analysis tasks up to the given number of times and asserts that that was enough.
- *
- * @param maxIterations the maximum number of tasks to perform
- */
- void _analyzeAll_assertFinished2(int maxIterations) {
+ void _analyzeAll_assertFinished([int maxIterations = 512]) {
for (int i = 0; i < maxIterations; i++) {
List<ChangeNotice> notice = context.performAnalysisTask().changeNotices;
if (notice == null) {
« pkg/analyzer/lib/src/context/context.dart ('K') | « pkg/analyzer/lib/src/context/context.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698