Validate modifications times only for sources.

pkg/analyzer/lib/src/context/context.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.context.context;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analyzer/src/cancelable_future.dart';
@@ skipping 1806 matching lines @@
    * does not match the modification time of the source associated with the
    * entry). Invalid entries will be marked as invalid so that the source will
    * be re-analyzed. Return `true` if at least one entry was invalid.
    */
   bool _validateCacheConsistency() {
     int consistencyCheckStart = JavaSystem.nanoTime();
     HashSet<Source> changedSources = new HashSet<Source>();
     HashSet<Source> missingSources = new HashSet<Source>();
     MapIterator<AnalysisTarget, CacheEntry> iterator = _cache.iterator();
     while (iterator.moveNext()) {
-      Source source = iterator.key.source;
-      if (source != null) {
+      AnalysisTarget target = iterator.key;
+      if (target is Source) {
+        Source source = target;

[Brian Wilkerson, 2015/05/12 01:03:22]

Or just use 'target' in the then block...

         CacheEntry entry = iterator.value;
         int sourceTime = getModificationStamp(source);
         if (sourceTime != entry.modificationTime) {
           changedSources.add(source);
         }
         if (entry.exception != null) {
           if (!exists(source)) {
             missingSources.add(source);
           }
         }
@@ skipping 193 matching lines @@
     PendingFuture pendingFuture =
         new PendingFuture<T>(_context, target, computeValue);
     if (!pendingFuture.evaluate(entry)) {
       _context._pendingFutureTargets
           .putIfAbsent(target, () => <PendingFuture>[])
           .add(pendingFuture);
     }
     return pendingFuture.future;
   }
 }