Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1130413010: Test that TypedArray methods don't read length (Closed)

Created:
5 years, 7 months ago by dehrenberg
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Test that TypedArray methods don't read length ES6 specifies that methods on TypedArrays reference an internal length slot, rather than their length property. This patch tests that for the TypedArray methods that exist currently. R=arv@chromium.org BUG=v8:3578 LOG=Y Committed: https://crrev.com/85c91f639e6779b1e5b19b1766bc64ccbe9f00dc Cr-Commit-Position: refs/heads/master@{#28409}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M test/mjsunit/harmony/typedarray-fill.js View 1 chunk +8 lines, -0 lines 2 comments Download
M test/mjsunit/harmony/typedarray-find.js View 1 chunk +10 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/typedarray-findindex.js View 1 chunk +10 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/typedarrays-every.js View 1 chunk +10 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/typedarrays-foreach.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
dehrenberg
5 years, 7 months ago (2015-05-15 00:23:12 UTC) #1
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/1130413010/diff/1/test/mjsunit/harmony/typedarray-fill.js File test/mjsunit/harmony/typedarray-fill.js (right): https://codereview.chromium.org/1130413010/diff/1/test/mjsunit/harmony/typedarray-fill.js#newcode42 test/mjsunit/harmony/typedarray-fill.js:42: Object.defineProperty(a, 'length', {value: 1}); or get: function() { ...
5 years, 7 months ago (2015-05-15 00:25:48 UTC) #2
dehrenberg
https://codereview.chromium.org/1130413010/diff/1/test/mjsunit/harmony/typedarray-fill.js File test/mjsunit/harmony/typedarray-fill.js (right): https://codereview.chromium.org/1130413010/diff/1/test/mjsunit/harmony/typedarray-fill.js#newcode42 test/mjsunit/harmony/typedarray-fill.js:42: Object.defineProperty(a, 'length', {value: 1}); On 2015/05/15 00:25:47, arv wrote: ...
5 years, 7 months ago (2015-05-15 01:40:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130413010/1
5 years, 7 months ago (2015-05-15 01:41:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 02:03:56 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 02:04:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85c91f639e6779b1e5b19b1766bc64ccbe9f00dc
Cr-Commit-Position: refs/heads/master@{#28409}

Powered by Google App Engine
This is Rietveld 408576698