Reland: Roll src/third_party/libsrtp 6446144:9c53f85 (svn 292694:295151)

Reland: Roll src/third_party/libsrtp 6446144:9c53f85 (svn 292694:295151)

This updates libsrtp to 1.5.2 and uses the OpenSSL/BoringSSL crypto code.
See https://codereview.chromium.org/889083003/ and https://codereview.chromium.org/1098043003/

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/libsrtp/+log/6446144..9c53f85

This previously landed in CL 981593002 but got reverted in CL 1131323002
as it broke the Windows GN bots. The GN script now adds BoringSSL to the
"public_deps" if necessary, so the include path is correct then.

BUG=328475
Committed: https://crrev.com/7c97ef229360cc10cae49569622bdfcba2d43f3c
Cr-Commit-Position: refs/heads/master@{#330066}

[fancycode, 2015-05-08 22:30:00]

mail@joachim-bauch.de changed reviewers:
+ gcasto@chromium.org, jiayl@chromium.org, juberti@chromium.org,
thakis@chromium.org

[fancycode, 2015-05-08 22:30:59]

Ptal, this should fix the issue that broke the Windows GN bots.

[joachim, 2015-05-11 16:40:47]

The windows gn trybots look good (besides the fact that they are flaky and don't
seem to have enough disk space for x64_dbg - already reported that to
chrome-troopers+tryserver@google.com), so I assume the issue seen before is
fixed.

Nico: could you please check if the new version is ok compared to
https://codereview.chromium.org/981593002?

[Nico, 2015-05-11 16:43:45]

I don't know why exactly it got reverted last time. Have you tried doing a
windows gn build locally and verified that your last attempt fails there and
this one doesn't?

[joachim, 2015-05-11 16:46:59]

On 2015/05/11 16:43:45, Nico wrote:
> I don't know why exactly it got reverted last time. Have you tried doing a
> windows gn build locally and verified that your last attempt fails there and
> this one doesn't?

Unfortunately I don't have a Windows machine available for testing, but it got
reverted as it couldn't find the BoringSSL include files when being built using
GN. The GN script therefore now adds BoringSSL to the "public_deps" (if compiled
with BoringSSL), so the include path for anything using libressl is correct in
that case.

[joachim, 2015-05-11 16:47:50]

On 2015/05/11 16:46:59, joachim wrote:
> On 2015/05/11 16:43:45, Nico wrote:
> > I don't know why exactly it got reverted last time. Have you tried doing a
> > windows gn build locally and verified that your last attempt fails there and
> > this one doesn't?
> 
> Unfortunately I don't have a Windows machine available for testing, but it got
> reverted as it couldn't find the BoringSSL include files when being built
using
> GN. The GN script therefore now adds BoringSSL to the "public_deps" (if
compiled
> with BoringSSL), so the include path for anything using libressl is correct in
> that case.

Err, make that libsrtp instead of libressl...

[jiayl, 2015-05-12 20:04:45]

lgtm

[joachim, 2015-05-12 21:33:51]

Nico: I think I'll also need a lgtm from you for the GN change in order to
submit this to CQ. Is there anything else you want me to test?

[Nico, 2015-05-14 04:15:17]

I wanted to test if this works in GN but didn't get around to it. lgtm, but
please be on irc (#chromium on freenode) when this lands, watch the gn bot, and
give the sheriffs a heads-up

[joachim, 2015-05-14 16:06:30]

On 2015/05/14 04:15:17, Nico wrote:
> I wanted to test if this works in GN but didn't get around to it. lgtm, but
> please be on irc (#chromium on freenode) when this lands, watch the gn bot,
and
> give the sheriffs a heads-up

Thanks for the detailed explanation. I won't be able to submit until sometime
tomorrow my time, so if you get around running this in GN until then, please let
me know.

How should I notify the sheriffs? Through irc before I submit to CQ, or is there
a dedicated email address I should use?

[Nico, 2015-05-14 20:50:01]

lgtm, I verified that things were broken with the old CL and these things work
with this CL. (Didn't do a full build though.)

Just saying "sheriffs: heads-up, I'm landing codereview.chromium.org/1130413005
, it broke win gn last time but should be good now" on irc is enough to let the
sheriffs know

[joachim, 2015-05-15 07:20:56]

The CQ bit was checked by jbauch@webrtc.org

[commit-bot: I haz the power, 2015-05-15 07:21:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130413005/1

[commit-bot: I haz the power, 2015-05-15 09:02:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-15 09:03:12]

Patchset 1 (id:??) landed as
https://crrev.com/7c97ef229360cc10cae49569622bdfcba2d43f3c
Cr-Commit-Position: refs/heads/master@{#330066}

[henrika (OOO until Aug 14), 2015-05-15 10:25:15]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1139233002/ by henrika@chromium.org.

The reason for reverting is: This CL most likely breaks Chrome. I can't find any
other reason to this issue:

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...

Reverting to see if it helps..