Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1130413003: Schedule garbage collection on worker threads using idle tasks (Closed)

Created:
5 years, 7 months ago by Sami
Modified:
5 years, 7 months ago
CC:
blink-reviews, falken, horo+watch_chromium.org, kinuko+worker_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Schedule garbage collection on worker threads using idle tasks Original patch by Alex Clarke <alexclarke@chromium.org>;. BUG=463143 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195243 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195402

Patch Set 1 #

Total comments: 2

Patch Set 2 : Style tweak. #

Patch Set 3 : Rebased. #

Total comments: 2

Patch Set 4 : Fix locking in test. #

Total comments: 3

Patch Set 5 : Remove overly specific tests. #

Patch Set 6 : Remove idle task wrapper. #

Patch Set 7 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -16 lines) Patch
M Source/core/workers/WorkerThread.h View 1 2 3 4 5 3 chunks +5 lines, -1 line 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 2 3 4 5 6 chunks +23 lines, -15 lines 0 comments Download
M Source/core/workers/WorkerThreadTest.cpp View 1 2 3 4 5 chunks +110 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (8 generated)
Sami
Jochen, PTAL.
5 years, 7 months ago (2015-05-08 18:14:55 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-11 23:30:22 UTC) #3
alex clarke (OOO till 29th)
https://codereview.chromium.org/1130413003/diff/1/Source/core/workers/WorkerThread.cpp File Source/core/workers/WorkerThread.cpp (right): https://codereview.chromium.org/1130413003/diff/1/Source/core/workers/WorkerThread.cpp#newcode378 Source/core/workers/WorkerThread.cpp:378: m_webScheduler->postIdleTaskAfterWakeup(FROM_HERE, new WorkerThreadIdleTask(this)); I wonder how this is going ...
5 years, 7 months ago (2015-05-12 08:42:14 UTC) #5
Sami
https://codereview.chromium.org/1130413003/diff/1/Source/core/workers/WorkerThread.cpp File Source/core/workers/WorkerThread.cpp (right): https://codereview.chromium.org/1130413003/diff/1/Source/core/workers/WorkerThread.cpp#newcode378 Source/core/workers/WorkerThread.cpp:378: m_webScheduler->postIdleTaskAfterWakeup(FROM_HERE, new WorkerThreadIdleTask(this)); On 2015/05/12 08:42:14, alexclarke1 wrote: > ...
5 years, 7 months ago (2015-05-12 10:05:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130413003/40001
5 years, 7 months ago (2015-05-12 10:29:55 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=195243
5 years, 7 months ago (2015-05-12 12:01:04 UTC) #10
Sami
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1128093003/ by skyostil@chromium.org. ...
5 years, 7 months ago (2015-05-12 16:01:58 UTC) #11
sadrul
https://codereview.chromium.org/1130413003/diff/40001/Source/core/workers/WorkerThread.cpp File Source/core/workers/WorkerThread.cpp (right): https://codereview.chromium.org/1130413003/diff/40001/Source/core/workers/WorkerThread.cpp#newcode509 Source/core/workers/WorkerThread.cpp:509: m_webScheduler->postIdleTask(FROM_HERE, new WorkerThreadIdleTask(this)); We already have too many ways ...
5 years, 7 months ago (2015-05-12 19:10:44 UTC) #13
Sami
https://codereview.chromium.org/1130413003/diff/40001/Source/core/workers/WorkerThread.cpp File Source/core/workers/WorkerThread.cpp (right): https://codereview.chromium.org/1130413003/diff/40001/Source/core/workers/WorkerThread.cpp#newcode509 Source/core/workers/WorkerThread.cpp:509: m_webScheduler->postIdleTask(FROM_HERE, new WorkerThreadIdleTask(this)); On 2015/05/12 19:10:44, sadrul wrote: > ...
5 years, 7 months ago (2015-05-12 19:15:43 UTC) #14
sadrul
On 2015/05/12 19:15:43, Sami wrote: > https://codereview.chromium.org/1130413003/diff/40001/Source/core/workers/WorkerThread.cpp > File Source/core/workers/WorkerThread.cpp (right): > > https://codereview.chromium.org/1130413003/diff/40001/Source/core/workers/WorkerThread.cpp#newcode509 > ...
5 years, 7 months ago (2015-05-13 04:45:21 UTC) #15
kinuko
On 2015/05/13 04:45:21, sadrul wrote: > Or maybe remove post-tasking from WebThread and move all ...
5 years, 7 months ago (2015-05-13 06:10:52 UTC) #17
Sami
I've now taken out the tests which were basically hardcoded against the scheduling policy we ...
5 years, 7 months ago (2015-05-13 17:54:19 UTC) #18
kinuko
https://codereview.chromium.org/1130413003/diff/60001/Source/core/workers/WorkerThread.cpp File Source/core/workers/WorkerThread.cpp (right): https://codereview.chromium.org/1130413003/diff/60001/Source/core/workers/WorkerThread.cpp#newcode311 Source/core/workers/WorkerThread.cpp:311: // can't use WTF::bind because the type-erasure for member ...
5 years, 7 months ago (2015-05-14 06:07:06 UTC) #19
alex clarke (OOO till 29th)
lgtm
5 years, 7 months ago (2015-05-15 09:51:09 UTC) #20
alex clarke (OOO till 29th)
lgtm
5 years, 7 months ago (2015-05-15 09:51:11 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130413003/10004
5 years, 7 months ago (2015-05-15 09:57:37 UTC) #24
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 10:00:42 UTC) #25
Message was sent while issue was closed.
Committed patchset #7 (id:10004) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195402

Powered by Google App Engine
This is Rietveld 408576698