Issue 1130403002: file_io_test: Use NoBarrier_Load() instead of Release_Load()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1130403002: file_io_test: Use NoBarrier_Load() instead of Release_Load() (Closed)

Created:
5 years, 7 months ago by Mark Mentovai

Modified:
5 years, 7 months ago

Reviewers:
JF, scottmg

CC:
crashpad-dev_chromium.org, Alexander Potapenko

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

file_io_test: Use NoBarrier_Load() instead of Release_Load(). BUG=chromium:420970 TEST=util_test FileIO.*Exclusive* R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/00c42ae7bdcf40d15c02b87e088c1eb565a51333

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	util/file/file_io_test.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

Committed patchset #1 (id:1) manually as 00c42ae7bdcf40d15c02b87e088c1eb565a51333 (presubmit successful).

5 years, 7 months ago (2015-05-08 18:15:17 UTC) #4

5 years, 7 months ago (2015-05-11 23:56:26 UTC) #6

Message was sent while issue was closed.

These two changes are likely invalid, and IIUC the first one can cause flaky
tests since there doesn't seem to be synchronization with the threads that just
got started. The second is mostly fine because join will end up getting a
barrier somewhere, but you're effectively using a relaxed operation without
really needing to.

Acquire_Load should be used in both cases instead.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages