[Media Gallery] Add existing attached devices to the prefs in time for media galleries dialog.

chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements the Chrome Extensions Media Galleries API.
 
 #include "chrome/browser/extensions/api/media_galleries/media_galleries_api.h"
 
 #include <set>
 #include <string>
@@ skipping 49 matching lines @@
   }
 
   return true;
 }
 
 }  // namespace
 
 MediaGalleriesGetMediaFileSystemsFunction::
     ~MediaGalleriesGetMediaFileSystemsFunction() {}
 
+bool MediaGalleriesGetMediaFileSystemsFunction::HasPermission() {
+  if (!ExtensionFunction::HasPermission())
+    return false;
+  MediaFileSystemRegistry::GetInstance()->AddAttachedMediaDeviceGalleries(

[vandebo (ex-Chrome), 2012/10/27 19:57:57]

I think putting this here abuses it's use.  Let just call it in the relevant
places in RunImpl()

[kmadhusu, 2012/10/28 01:13:43]

Moved this function call to the top of RunImpl() function. I guess irrespective
of the interactive mode, we want to add the attached device galleries to the
preferences.

+      render_view_host());
+  return true;
+}
+
 bool MediaGalleriesGetMediaFileSystemsFunction::RunImpl() {
   if (!ApiIsAccessible(&error_))
     return false;
 
   scoped_ptr<GetMediaFileSystems::Params> params(
       GetMediaFileSystems::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
   MediaGalleries::GetMediaFileSystemsInteractivity interactive =
       MediaGalleries::MEDIA_GALLERIES_GET_MEDIA_FILE_SYSTEMS_INTERACTIVITY_NO;
   if (params->details.get() && params->details->interactive != MediaGalleries::
@@ skipping 118 matching lines @@
 bool MediaGalleriesAssembleMediaFileFunction::RunImpl() {
   if (!ApiIsAccessible(&error_))
     return false;
 
   // TODO(vandebo) Update the metadata and return the new file.
   SetResult(Value::CreateNullValue());
   return true;
 }
 
 }  // namespace extensions