sdk/lib/_internal/compiler/implementation/compile_time_constants.dart - Issue 11304021: Add NativeEnqueuer to work with the Enqueuer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

Issue 11304021: Add NativeEnqueuer to work with the Enqueuer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add --enable-native-live-type-analysis Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/apiimpl.dart ('k') | sdk/lib/_internal/compiler/implementation/compiler.dart » ('j') | sdk/lib/_internal/compiler/implementation/compiler.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

diff --git a/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart b/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

index 62bfa821fed27476c60e33ac971f777ebdcbd008..5805875abbce5d8e06d808b5c8522edcdc896f26 100644

--- a/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

+++ b/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

@@ -251,7 +251,7 @@ class CompileTimeConstantEvaluator extends Visitor {

this.elements,

this.compiler,

{bool isConst})

- : this.isEvaluatingConstant = isConst;

+ : this.isEvaluatingConstant = isConst == null ? false : isConst;

ahe 2012/11/14 13:51:30 I prefer the fix I have in https://codereview.chro

sra1 2012/11/15 00:09:10 I will merge your fix.

Constant evaluate(Node node) {

return node.accept(this);