Add support at test for /PROFILE in Ninja

Add support at test for /PROFILE in Ninja

On Windows, have Ninja scan VCLinkerTool to a 'Profile' key.
If 'true', then set the '/PROFILE' switch.

This feature is neede to support syzygy

BUG=126499
TEST=gyptest-ninja-link-flags
Committed: https://code.google.com/p/gyp/source/detail?r=1526

[scottmg, 2012-10-26 20:31:57]

https://codereview.chromium.org/11304012/diff/1/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

https://codereview.chromium.org/11304012/diff/1/pylib/gyp/msvs_emulation.py#n...
pylib/gyp/msvs_emulation.py:405: ld('Profile', map={ 'false': '', '': '',
'true': '/PROFILE'})
remove all but the 'true' case (other values with disappear)

https://codereview.chromium.org/11304012/diff/1/test/win/gyptest-ninja-link-f...
File test/win/gyptest-ninja-link-flags.py (right):

https://codereview.chromium.org/11304012/diff/1/test/win/gyptest-ninja-link-f...
test/win/gyptest-ninja-link-flags.py:78: if not
VerifyLdSwitch('test_ninja_profile_true.ninja',
We've generally tried hard to not have tests like this. Specifically, not
verifying that the text emitted is what we said to emit, but rather that there's
some effect on the target binary instead, or a preprocessor definition that
changes. i.e. the result of the change, rather than the specific implementation.

That way, the test will also work on msvs (or hypothetically some other build
tool).

[scottmg, 2012-10-26 20:36:46]

Also, apparently this doesn't actually work in most builds of VS (Enterprise+
only):

http://msdn.microsoft.com/en-us/library/ays5x7b0(v=vs.100).aspx

Is it really /PROFILE that's needed, or is it /FIXED:NO so that there's
relocations or something instead?

[scottmg, 2012-10-26 20:42:37]

d:\src\cr2\src>type a.cc
int data = 434;
__declspec(dllexport) int x() {
  return data;
}
int main() {
}

d:\src\cr2\src>x

d:\src\cr2\src>cl /nologo /Ox a.cc /link /fixed /out:a.exe
a.cc
   Creating library a.lib and object a.exp

d:\src\cr2\src>cl /nologo /Ox a.cc /link /fixed:no /out:b.exe
a.cc
   Creating library b.lib and object b.exp

d:\src\cr2\src>dumpbin /headers a.exe   | grep "Relocations stripped"
                   Relocations stripped

d:\src\cr2\src>dumpbin /headers b.exe   | grep "Relocations stripped"


If that's sufficient, there's a dumpbin helper in the test runner that we use in
other tests. Otherwise, maybe you can figure out whatever other effect it is
that syzygy needs and test for that.

[noelallen1, 2012-10-27 23:22:00]

Reworked as recommended.  Now using dumpbin, and now supports both msvs & ninja
configs.

http://codereview.chromium.org/11304012/diff/1/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

http://codereview.chromium.org/11304012/diff/1/pylib/gyp/msvs_emulation.py#ne...
pylib/gyp/msvs_emulation.py:405: ld('Profile', map={ 'false': '', '': '',
'true': '/PROFILE'})
On 2012/10/26 20:31:57, scottmg wrote:
> remove all but the 'true' case (other values with disappear)

Done.

http://codereview.chromium.org/11304012/diff/1/test/win/gyptest-ninja-link-fl...
File test/win/gyptest-ninja-link-flags.py (right):

http://codereview.chromium.org/11304012/diff/1/test/win/gyptest-ninja-link-fl...
test/win/gyptest-ninja-link-flags.py:78: if not
VerifyLdSwitch('test_ninja_profile_true.ninja',
Switched to using dumpbin to verify.

On 2012/10/26 20:31:57, scottmg wrote:
> We've generally tried hard to not have tests like this. Specifically, not
> verifying that the text emitted is what we said to emit, but rather that
there's
> some effect on the target binary instead, or a preprocessor definition that
> changes. i.e. the result of the change, rather than the specific
implementation.
> 
> That way, the test will also work on msvs (or hypothetically some other build
> tool).

[scottmg, 2012-10-29 15:33:33]

Other than that, lgtm, thanks.

Is this going to fail on bots though?
http://msdn.microsoft.com/en-us/library/ays5x7b0(v=vs.100).aspx says Enterprise
version only, which I don't think most people have installed. Maybe bots do
though?

(Is it working for you locally with a non-Enterprise version?)

http://codereview.chromium.org/11304012/diff/10001/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

http://codereview.chromium.org/11304012/diff/10001/pylib/gyp/msvs_emulation.p...
pylib/gyp/msvs_emulation.py:405: ld('Profile', map={ 'false': '', '': '',
'true': '/PROFILE'})
forgot this one?

[noelallen1, 2012-10-29 20:22:22]

I have an enterprise version installed I believe.  As it is, it does pass the
Windows ninja and msvs portion of the try.  And as for Chrome, since we need it,
we must be able to use it.

[scottmg, 2012-10-29 20:27:36]

Hmm, my non-Enterprise version has a /PROFILE switch, so I guess the docs are
wrong. (?) Anyway, we can figure out a way to conditionally disable running the
test if we need to later.

http://codereview.chromium.org/11304012/diff/20004/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

http://codereview.chromium.org/11304012/diff/20004/pylib/gyp/msvs_emulation.p...
pylib/gyp/msvs_emulation.py:405: ld('Profile', map={ 'true': '/PROFILE'})
nit: extra space here