Chromium Code Reviews
Help | Chromium Project | Sign in
(126)

Issue 11304012: Add support at test for /PROFILE in Ninja (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by noelallen1
Modified:
1 year, 5 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Add support at test for /PROFILE in Ninja

On Windows, have Ninja scan VCLinkerTool to a 'Profile' key.
If 'true', then set the '/PROFILE' switch.

This feature is neede to support syzygy

BUG=126499
TEST=gyptest-ninja-link-flags
Committed: https://code.google.com/p/gyp/source/detail?r=1526

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -0 lines) Lint Patch
M pylib/gyp/msvs_emulation.py View 1 2 3 1 chunk +1 line, -0 lines 1 comment 0 errors Download
A test/win/gyptest-link-profile.py View 1 1 chunk +37 lines, -0 lines 0 comments ? errors Download
A test/win/linker-flags/profile.gyp View 1 1 chunk +50 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 9
noelallen1
1 year, 5 months ago #1
scottmg
https://codereview.chromium.org/11304012/diff/1/pylib/gyp/msvs_emulation.py File pylib/gyp/msvs_emulation.py (right): https://codereview.chromium.org/11304012/diff/1/pylib/gyp/msvs_emulation.py#newcode405 pylib/gyp/msvs_emulation.py:405: ld('Profile', map={ 'false': '', '': '', 'true': '/PROFILE'}) remove ...
1 year, 5 months ago #2
scottmg
Also, apparently this doesn't actually work in most builds of VS (Enterprise+ only): http://msdn.microsoft.com/en-us/library/ays5x7b0(v=vs.100).aspx Is ...
1 year, 5 months ago #3
scottmg
d:\src\cr2\src>type a.cc int data = 434; __declspec(dllexport) int x() { return data; } int main() ...
1 year, 5 months ago #4
noelallen1
1 year, 5 months ago #5
noelallen1
Reworked as recommended. Now using dumpbin, and now supports both msvs & ninja configs. http://codereview.chromium.org/11304012/diff/1/pylib/gyp/msvs_emulation.py ...
1 year, 5 months ago #6
scottmg
Other than that, lgtm, thanks. Is this going to fail on bots though? http://msdn.microsoft.com/en-us/library/ays5x7b0(v=vs.100).aspx says ...
1 year, 5 months ago #7
noelallen1
I have an enterprise version installed I believe. As it is, it does pass the ...
1 year, 5 months ago #8
scottmg
1 year, 5 months ago #9
Hmm, my non-Enterprise version has a /PROFILE switch, so I guess the docs are
wrong. (?) Anyway, we can figure out a way to conditionally disable running the
test if we need to later.

http://codereview.chromium.org/11304012/diff/20004/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

http://codereview.chromium.org/11304012/diff/20004/pylib/gyp/msvs_emulation.p...
pylib/gyp/msvs_emulation.py:405: ld('Profile', map={ 'true': '/PROFILE'})
nit: extra space here
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6